search

C9Glax / tranga-website

Web-Frontend for Tranga-API
GNU General Public License v3.0
17 stars 10 forks source link

Frontend v2 #84

Open db-2001 opened 4 months ago

db-2001 commented 4 months ago

Draft PR for V2 of the front-end, will implement the JSON api once server side is set up so I can test with it.

Addresses #83 Addresses #59 Addresses #79

db-2001 commented 4 months ago

Preview of the search window changes (full functionality isn't there yet). Will link to issues once I commit

OLD: image image

NEW: image

db-2001 commented 4 months ago

Resolves #64 Resolves #46 Resolves #40 Resolves #21 Resolves #52

db-2001 commented 4 months ago

Finalized search window: image Combined download button and in-library indicator so it's clear that you can't readd a manga (I know the API technically allows this but seems like weird behavior)

db-2001 commented 4 months ago

image

Hovering over the manga name in the search window lets you click it and you get sent to the manga connector. Currently implemented for search window, need to remember to do it for manga details window.

db-2001 commented 4 months ago

image

New Progress Bar that looks the same on all platforms. I can't figure out why the animations don't want to work the same as Firefox on Chrome and Edge tho but both do have animations, they just look very different.

C9Glax commented 4 months ago

Combined download button and in-library indicator so it's clear that you can't re-add a manga (I know the API technically allows this but seems like weird behavior)

I think it just doesn't add the job, but doesn't respond an error code if it was unsuccessful...

db-2001 commented 3 months ago

Updated the manga viewer pop-up. I thought we had the ability to individually download select chapters in the API but I'm not seeing it. We don't need it For V2 of Tranga, we can keep it as something that we do eventually. With this I'll be forking over the new API code and then over the next couple weeks, tweaking the behavior to work with it. Before: image After: image

Also made some basic CSS changes to help with mobile devices: Before: image

After: image

db-2001 commented 3 weeks ago

Hey @C9Glax, I'm really sorry for being MIA for a few months, I've been really busy trying to get setup in a new city with a new job.

I feel really bad about leaving this PR in what I consider an unfinished state but I don't know if I'll be able to get the time to finish off the API migration. I've changed the base to dev, would you be able to take it from here? I think there are some really nice UI tweaks and improvements which I'd like to share with everyone. (Any feedback is welcome of course)

As for the API migration which took me the longest, it's still very not optimized for how the new API calls work, I tried to improve it and start from scratch the javascript about 3 times but it ended up being too much for me to do, so sorry about that :( . I think for the most part, everything works like it used to with the old API, but there's something funky going on with the running/waiting jobs that I'm not able to figure out.

As for the future, I do hope and wish to continue contributing to the frontend, but maybe in smaller chunks so I can actually get stuff done, haha,

C9Glax commented 2 weeks ago

Hey! Do not feel guilty or pressured to work on this. I am very grateful for everything you have already contributed, and will wait with open arms for when/if you have the time, energy and will to add/fix another issue :)

I tried pulling some of your fixes in the past month, but did not get very far yet, especially on the frontend this project is still lacking, so I look forward to the day I can release your changes 👍🏼

I hope you will like both city and job, until we write again. Glax