[It broke]: Add support for the ' character in file and directory names

theAlevan commented 4 months ago

What is broken?

It seems that tranga does not support the ' character in file and directory names, and renames them to either "rsquo" or "039"

Log-output

No response

Additional stuff

Examples:

Academyrsquos Genius Swordmaster instead of Academy's Genius Swordmaster

I039m an Evil God instead of I'm an Evil God

C9Glax commented 4 months ago

Hey, just to see if this is a Connector specific thing: What Website are you using?

But my guess would be that it is encoded that way in the HTML-sourcecode, so I would have to simply write a check for that sort of thing.

theAlevan commented 4 months ago

I'm using Manganato and Mangakatana, and it happens on both of them.

C9Glax commented 4 months ago

Okay, can you try again please? Just updated cuttingedge-branch with a potential fix.

Change in the docker-compose.yaml

services:
  tranga-api:
    image: glax/tranga-api:cuttingedge

theAlevan commented 4 months ago

On the web interface, and in the logs the manhua the ' character now shows up correctly, but it still creates the download folder without the ' character (see the upper folder on the screenshoot).

Logs:

[07/31/2024 19:26:25.241]       JobBoss | Adding Job to Queue. Tranga.Jobs.DownloadChapter-aW1hbmV2aWxnb2QyMDI0-474 Chapter: **Chapter I'm an Evil God** aW1hbmV2aWxnb2QyMDI0 1
[07/31/2024 19:26:25.242]       JobBoss | Adding Job to Queue. Tranga.Jobs.UpdateMetadata-aW1hbmV2aWxnb2QyMDI0 Manga: Publication I'm an Evil God aW1hbmV2aWxnb2QyMDI0
[07/31/2024 19:26:25.343]       JobBoss | Next job in -00:00:00.0000007 Tranga.Jobs.DownloadChapter-aW1hbmV2aWxnb2QyMDI0-473
[07/31/2024 19:26:25.444]   MangaKatana | Copy cover Publication I'm an Evil God aW1hbmV2aWxnb2QyMDI0
[07/31/2024 19:26:25.445]       JobBoss | Exporting Job /usr/share/tranga-api/jobs/Tranga.Jobs.DownloadChapter-aW1hbmV2aWxnb2QyMDI0-1.json
[07/31/2024 19:26:25.448]   MangaKatana | Cover exists Publication I'm an Evil God aW1hbmV2aWxnb2QyMDI0
[07/31/2024 19:26:25.449]   MangaKatana | Retrieving chapter-info Chapter I'm an Evil God aW1hbmV2aWxnb2QyMDI0 1 I Crossed Over And Fell Into The Vixen’s Lair Publication I'm an Evil God aW1hbmV2aWxnb2QyMDI0
[07/31/2024 19:26:26.402]   MangaKatana | Downloading Images for **/Manga/I039m an Evil God/I039m an Evil God** - Ch.1 - I Crossed Over And Fell Into The Vixens Lair.cbz

C9Glax commented 4 months ago

Ah yeah, missed that bit. One more try please 👍🏼

theAlevan commented 4 months ago

It works, thank you!

C9Glax / tranga