[charts/portal] Add env var HTTPD_USE_SSL_CERT_CHAIN to use certificate chain for di…

CAAPIM / apim-charts

Helm Charts for Layer7 API Management components.

MIT License

12 stars 48 forks source link

[charts/portal] Add env var HTTPD_USE_SSL_CERT_CHAIN to use certificate chain for di… #128

Closed acheuk closed 2 years ago

acheuk commented 2 years ago

…spatcher.

Description of the change

Add environment variable to show certificate chain for dispatcher.

Benefits

Drawbacks

Applicable issues

fixes #

Additional information

Checklist

[] Chart version bumped in Chart.yaml according to semver.
[] Variables are documented in the README.md
[] Title of the PR starts with chart name (e.g. [charts/gateway])
[] If the chart contains a values-production.yaml apart from values.yaml, ensure that you implement the changes in both files

melil02 commented 2 years ago

@scottchc1 do you think for those edge cases we need to expose it as separate variable or use additional values? Or not document it at all? I think we should introduce HTTPD_USE_SSL_CERT_CHAIN standalone in this case

scottchc1 commented 2 years ago

i don't know enough about what use case this change serves. maybe @Gazza7205 can review? i would treat additionalEnv meant to be optional, and should be empty in most standard deployment. so if this env must exist and have a default value (doesn't matter true or false, as long as the env key need to exist), then declare it explicitly.

acheuk commented 2 years ago

I think this should be an optional variable. @melil02, can you confirm?

melil02 commented 2 years ago

Agree, lets not expose it for now.

Gazza7205 commented 2 years ago

@acheuk - should we close this PR or do you want to keep it open?

acheuk commented 2 years ago

Closing this PR per comment above.