search

CAAPIM / apim-charts

Helm Charts for Layer7 API Management components.
MIT License
12 stars 48 forks source link

The use of the 'describe' verb is not valid. #130

Closed GerbenWelter closed 2 years ago

GerbenWelter commented 2 years ago

There is no validation of verb names in Kubernetes so this won't cause an error but it also won't do anything. The 'get' verb is enough for getting the jobs and their status.

It will generate an error if the account creating the role has been restricted in what it can create.

Description of the change

Removes invalid verb from kubernetes Role.

Benefits

This prevents an error when installing the helm chart with an account that is only allowed to 'get' Jobs.

Drawbacks

None known.

Additional information

Allowing the verb 'describe' has no use because it's not a valid verb anyway.

Gazza7205 commented 2 years ago

Looks good to me - could you update the Chart version in Chart.yaml?

@APIM-KiranVaddadi @ksaladi