Read os env vars - Githubissues

CAAPIM / apim-charts

Helm Charts for Layer7 API Management components.

MIT License

12 stars 48 forks source link

Read os env vars #158

Open DamandeepToor opened 2 years ago

DamandeepToor commented 2 years ago

Description of the change

Adding environment variables to be read by the Gateway

Benefits

Example to add environment variables as secret variables and read via Gateway context variable syntax in Policy and in pre-selected configuration fields (e.g. JDBC Connection URL)

Drawbacks

Applicable issues

fixes #

Additional information

Checklist

[] Chart version bumped in Chart.yaml according to semver.
[] Variables are documented in the README.md
[] Title of the PR starts with chart name (e.g. [charts/gateway])
[] If the chart contains a values-production.yaml apart from values.yaml, ensure that you implement the changes in both files

Gazza7205 commented 2 years ago

The repo that you are trying to merge is 258 commits behind stable.

Do we need an additional template for this? AdditionalEnv/Secrets can already be configured here - https://github.com/CAAPIM/apim-charts/blob/stable/charts/gateway/values.yaml#L453-L461

For production environments we advise against exposing secrets in values.yaml - it's best to make use of existingSecrets where applicable

DamandeepToor commented 2 years ago

@Gazza7205 , oh may be you are right, let me merge the stable to this PR and add the env to https://github.com/CAAPIM/apim-charts/blob/stable/charts/gateway/values.yaml#L453-L461

Gazza7205 commented 2 years ago

@Gazza7205 , oh may be you are right, let me merge the stable to this PR and add the env to https://github.com/CAAPIM/apim-charts/blob/stable/charts/gateway/values.yaml#L453-L461

Do we need an additional template for this given that we already have mechanisms in place?

Sounds like we just need to update the readme.

DamandeepToor commented 2 years ago

@Gazza7205 , oh may be you are right, let me merge the stable to this PR and add the env to https://github.com/CAAPIM/apim-charts/blob/stable/charts/gateway/values.yaml#L453-L461

Do we need an additional template for this given that we already have mechanisms in place?

Sounds like we just need to update the readme.

Updated ReadMe and revert other changes.

Gazza7205 commented 2 years ago

@Gazza7205 , oh may be you are right, let me merge the stable to this PR and add the env to https://github.com/CAAPIM/apim-charts/blob/stable/charts/gateway/values.yaml#L453-L461

Do we need an additional template for this given that we already have mechanisms in place? Sounds like we just need to update the readme.

Updated ReadMe and revert other changes.

It seems this readme is also from an old branch - could you review your changes and make sure they are against the latest stable commit?