search

CAAPIM / apim-charts

Helm Charts for Layer7 API Management components.
MIT License
12 stars 48 forks source link

Parametrize enabling restman in portal ingress #179

Closed cuisimon closed 1 year ago

cuisimon commented 1 year ago

Please note that this is for internal use only, basically to be able to run RAT tests on Portal.

However, it will expose the functionality to portal customers if merge the PR to develop/portal, then stable.

Thus will need portal PMs/POs/Dev to decide on whether or not to include the function to the portal helm chart.

cuisimon commented 1 year ago

Hi @Gazza7205, @SatishKoney-BRCM, @melil02 Do you have any thoughts for the PR? still waiting for any comments.. should we merge or abandon it?

jmmAVGO commented 1 year ago

@cuisimon Tweak needed: apim-deployment.yaml specifies restman.enabled, but values.yaml specifies restman.enable.

It sounded to me from our discussions this week that this would still be a valuable change for us internally. Is this type of Restman installation something that has no value to customers? I don't know the product well enough to answer that question..

@Gazza7205 @SatishKoney-BRCM @melil02 - if this approach is fundamentally okay, can you let us know what adjustments are needed? If a new approach is needed, can you help us determine a path forward? If this is something we don't want to deal with in this repo, let's figure that out so this PR can be closed.

jmmAVGO commented 1 year ago

Sandeep says Ilya says this is not the way we are doing this, so I'm going to close this PR.