Recently, we began attempting portal deployments with replicaCount: 2 for most pods/services, instead of 1. I discovered that analytics and minio have checks for how many replicas are being deployed; however, those checks do a helm comparison against the value '1.0'; this is odd/inconsistent, since the value will always be an int, and is represented as such elsewhere. This change casts the value to an int before comparing it to '1'.
Benefits
Users will be able to deploy more than one analytics and minio pod in a manner consistent with other pods.
Drawbacks
I am somewhat concerned about Chart.lock. I am not super familiar with building helm charts, and attempted to do 'helm dependency update druid', but it had no effect; attempting 'helm dependency update' failed because of issues accessing bitnami charts/urls. So, please ensure I've made this change in a safe way.
If or when this change is accepted, I imagine we'll likely wish to introduce it to other branches.
fixes #
Additional information
Preparing to commit a top-level version change to Chart.yaml, per the checklist below.
Checklist
[x] Chart version bumped in Chart.yaml according to semver.
[x] Variables are documented in the README.md
[x] Title of the PR starts with chart name (e.g. [charts/gateway])
[x] If the chart contains a values-production.yaml apart from values.yaml, ensure that you implement the changes in both files
Description of the change
Recently, we began attempting portal deployments with replicaCount: 2 for most pods/services, instead of 1. I discovered that analytics and minio have checks for how many replicas are being deployed; however, those checks do a helm comparison against the value '1.0'; this is odd/inconsistent, since the value will always be an int, and is represented as such elsewhere. This change casts the value to an int before comparing it to '1'.
Benefits
Users will be able to deploy more than one analytics and minio pod in a manner consistent with other pods.
Drawbacks
I am somewhat concerned about Chart.lock. I am not super familiar with building helm charts, and attempted to do 'helm dependency update druid', but it had no effect; attempting 'helm dependency update' failed because of issues accessing bitnami charts/urls. So, please ensure I've made this change in a safe way.
If or when this change is accepted, I imagine we'll likely wish to introduce it to other branches.
Additional information
Preparing to commit a top-level version change to Chart.yaml, per the checklist below.
Checklist
Chart.yamlaccording to semver.[charts/gateway])values-production.yamlapart fromvalues.yaml, ensure that you implement the changes in both files