Closed jmmAVGO closed 1 year ago
@APIM-KiranVaddadi Scott iis asking iif you can review this problem; it may exist elsewhere, including the new method of installing otk inside the gateway helm chart
This chart is new deprecated. The change needs to be done here https://github.com/CAAPIM/apim-charts/blob/stable/charts/gateway/templates/otk-install-job.yaml#L54
@APIM-KiranVaddadi That may very well be, but releng is still using this chart, and we need it until we don't. Do you want to make the PR for the stable / gateway chart?
@Gazza7205 @APIM-KiranVaddadi , just to be clear, we're applying this fix for our internal pipeline. we're leaving fixing the gateway chart to you.
This PR ensures that arguments passed as part of the JDBC connectiioin string are properly escaped when inserted into bunndle files. For example, jdbc-connection-oauth.bundle should read:
iinsntead of:
Benefits
This will allow OTK installatioins that use SSL to succeed
Drawbacks
Not a drawback, per se, but I wonder if this is complete? I don't know a lot about bundle files - are there other thingns that need to be escaped? Also, I assume I should open another PR against 'stable' after this?
Applicable issues
Additional information
Checklist
Chart.yaml
according to semver.[charts/gateway]
)values-production.yaml
apart fromvalues.yaml
, ensure that you implement the changes in both files