CAAPIM / apim-charts

Helm Charts for Layer7 API Management components.
MIT License
11 stars 48 forks source link

[charts/druid, charts/portal] add PDB support #222

Closed jmmAVGO closed 1 year ago

jmmAVGO commented 1 year ago

Description of the change

This PR allows the use of PodDisruptionBudgets (PDBs) for Portal containers. Though the default minAvailable setting is 1, pdb: create is set to 'false' by default. Thus, PDBs are disabled unless otherwise specified.

Benefits

These changes facilitate more resilient Portal deployments.

Drawbacks

Users should be familiar with PDBs before utilizing them.

Additional information

Please note that this PR makes me realize that GW/OTK charts don't specify a minAvailable or maxUnavailable value (they must be specified by the user). This PR is slightly different. We should probably adopt a uniform approach; either I should modify this PR to match those, or I should create subsequent PRs to make those match this one. Thoughts?

Checklist

jmmAVGO commented 1 year ago

Do you all have thoughts on setting default minAvailability (typically to one) to 1 vs. not setting a value? Like I said, this takes a different approach than gw/otk, and I think we should be consistent with whichever we choose.