CAAPIM / react-themer

React bindings for https://github.com/CAAPIM/themer

MIT License

1 stars 1 forks source link

feat: Dynamic theme updating #65

Closed avivash closed 7 years ago

avivash commented 7 years ago

Status

READY

Description

This PR adds a componentDidUpdate lifecycle listener to detect if the globalTheme differs from the currentTheme of the decorated component. If the two don't match, the theme attributes are re-resolved based on the new globalTheme.

Impacted Areas in Application

List general components of the application that this PR will affect:

src/react-themer/index.js

codecov-io commented 7 years ago

Codecov Report

Merging #65 into master will not change coverage. The diff coverage is 100%.

@@          Coverage Diff          @@
##           master    #65   +/-   ##
=====================================
  Coverage     100%   100%           
=====================================
  Files           4      4           
  Lines          38     48   +10     
  Branches       11     14    +3     
=====================================
+ Hits           38     48   +10