search

CABLE-LSM / CABLE-Trac-archive

Archive CABLE Trac contents as issues
Other
0 stars 0 forks source link

Bandaid fix for commented CASA code #100

Closed penguian closed 8 years ago

penguian commented 8 years ago

keyword_compiler_nogit owner:yxw599@nci.org.au resolution_fixed type_defect | by ned@nedhaughton.com

The CASA code contains a subroutine, ncdf_dump, that has all of its contents commented out. This means that compilers set its arguments to default types, and that causes an error during compilation with -check all or -pedantic, because of type mismatching.

the change in https://trac.nci.org.au/trac/cable/browser/branches/Users/nnh561/casa_comment_fix fixes the problem for now, by commenting out the whole subroutine, and the one place where it occurs in code. Later on, this code should be dealt with properly. The change is: https://trac.nci.org.au/trac/cable/changeset/3567

This change does not affect the offline or ACCESS results:

Issue migrated from trac:100 at 2023-11-27 11:15:22 +1100

penguian commented 8 years ago

@jxs599@nci.org.au changed status from new to closed

penguian commented 8 years ago

@jxs599@nci.org.au changed resolution from ` tofixed`

penguian commented 8 years ago

@jxs599@nci.org.au changed milestone from step 1 - validation to step 7 - finalised

penguian commented 8 years ago

@jxs599@nci.org.au commented

This fix is added to the trunk (-38c5850d8da2f7035de7bbe181fe709b01441cd4) to expedite/faciltate Jenkins testing. Reviewing this Ticket properly is the subject of new Ticket #101

penguian commented 1 year ago

@ccc561@nci.org.au changed keywords from compiler to compiler nogit