Closed penguian closed 8 years ago
@jxs599@nci.org.au changed status from new
to closed
@jxs599@nci.org.au changed resolution from ` to
fixed`
@jxs599@nci.org.au edited the issue description
removed milestone (was step 6 - approval
)
commented
Milestone step 6 - approval deleted
@jxs599@nci.org.au changed milestone from ` to
1. Closed`
@ccc561@nci.org.au changed keywords from app, veg, vegin, parameters
to app, veg, vegin, parameters nogit
keyword_app
keyword_parameters_nogit
keyword_veg
keyword_vegin
resolution_fixed
type_defect
| by srb001@csiro.auCABLE (science) model uses type veg% to describe vegetation parameters. these are read in from a file def_veg_params using code in cable_common, used in both online/offline modes, and read into a temporary type vegin%. the vegin% parameters are then attributed to veg%. this was done separately for offline and online. Inspection of GPP in offline mode pointed to a bug in the attribution of vegin% to veg%.
Fix: The code was modified to include correct vegin% --->> veg% attribution, and moved to cable_common, so both offline and online use the same code.
There is further cleaning up to in this area such as clean the hard wiring of root etc. but we will leave that for a future ticket #103
Work in branch: https://trac.nci.org.au/svn/cable/branches/Share/Tickets2016/Ticket102
Fix @ -6ae215ba23aae5597fa6c8c4a301a86abf06bdb2
Issue migrated from trac:102 at 2023-11-27 11:15:36 +1100