search

CABLE-LSM / CABLE-Trac-archive

Archive CABLE Trac contents as issues
Other
0 stars 0 forks source link

floating point overflow in subroutine photosynthesis #117

Closed penguian closed 6 years ago

penguian commented 8 years ago

keyword_nogit resolution_fixed type_defect | by bep599

There are some instances where one of anrubiscoz or anrubpz or ansinkz becomes undefined in single-precision runs. The problem arose from the conditional statement introduced by kdcorbin 09/10 did not encompass all the conditions. The suggested fix would be to strip off the conditional statement so that the variables ciz and an* are initialized as 99999.0 at all times. !kdcorbin, 09/10 - new calculations

           ! no solution, give it a huge number

           !IF( ABS( coef2z(i,j) ) < 1.0e-9 .AND.                & ! MJT fix

           !    ABS( coef1z(i,j) ) < 1.0e-9 ) THEN                 ! MJT fix

              ciz(i,j) = 99999.0

              anrubpz(i,j)  = 99999.0

           !ENDIF                                                  ! MJT fix

Issue migrated from trac:117 at 2023-11-27 11:17:19 +1100

penguian commented 8 years ago

@bep599@nci.org.au edited the issue description

penguian commented 7 years ago

@jxs599@nci.org.au changed milestone from 6. Report to 3. Implementation

penguian commented 7 years ago

@jxs599@nci.org.au changed status from new to closed

penguian commented 7 years ago

@jxs599@nci.org.au changed resolution from ` tofixed`

penguian commented 7 years ago

@jxs599@nci.org.au changed milestone from 3. Implementation to 1. Closed

penguian commented 7 years ago

@jxs599@nci.org.au commented

Pushed to Quasi trunk

penguian commented 7 years ago

@jxs599@nci.org.au changed milestone from 1. Closed to 2. Submission

penguian commented 7 years ago

@jxs599@nci.org.au changed status from closed to reopened

penguian commented 7 years ago

@jxs599@nci.org.au changed resolution from fixed to ``

penguian commented 7 years ago

@jxs599@nci.org.au changed milestone from 2. Submission to 1. Closed

penguian commented 6 years ago

@jxs599@nci.org.au changed status from reopened to closed

penguian commented 6 years ago

@jxs599@nci.org.au changed resolution from ` tofixed`

penguian commented 1 year ago

@ccc561@nci.org.au set keywords to nogit