internal inconsistency in canopy%fwet

penguian commented 7 years ago

keyword_canopy%fwet_nogit resolution_fixed type_defect | by inh599

The variable canopy%fwet is calculated in (at least) three occasions within cable_canopy

i) within surf_wetness_fact (i.e. once per call before the main iteration loop)
ii) within dryLeaf (if %vlaiw > %LAI_THRESH)
iii) within wetLeaf (if %vlaiw > %LAI_THRESH)

The value set within surf_wetness_fact differs from that in dryLeaf and wetLeaf, if the LAI threshold is exceeded (it is limited to <0.9 not <1.0). As it appears that %fwet is not used unless the LAI threshold is exceeded, the value given in surf_wetness_fact is NOT used within CABLE. Also there is no physical reason why the value should vary during the iteration loop.

For internal consistency the three calculations need to be made to be consistent and/or (preferably for efficiency and code legibility) the calculations within dryLeaf and wetLeaf removed.

The current implementation risks the creation of bugs into the future as researchers are unaware of the different locations where %fwet is determined.

Issue migrated from trac:134 at 2023-11-27 11:19:18 +1100

penguian commented 7 years ago

@jxs599@nci.org.au changed milestone from Report to Closed

penguian commented 7 years ago

@jxs599@nci.org.au changed milestone from 1. Closed to 6. Report