search

CABLE-LSM / CABLE-Trac-archive

Archive CABLE Trac contents as issues
Other
0 stars 0 forks source link

Bug fix that increases diffuse radiation canopy reflectance by a factor of 2 #147

Closed penguian closed 7 years ago

penguian commented 7 years ago

keyword_albedo keyword_diffuse_radiation_nogit owner:vxh599@nci.org.au resolution_fixed type_defect | by vxh599

Critical fix to canopy reflectance for diffuse radiation in cable_radiation.F90. Code committed in https://trac.nci.org.au/trac/cable/browser/branches/Users/vxh599/trunk_checks_extract_sli/core/biogeophys/cable_radiation.F90

! Canopy REFLection of diffuse radiation for black leaves: DO ictr=1,nrb

!!$ rad%rhocdf(:,ictr) = rhoch(:,ictr) & !!$ ( C%GAUSS_W(1) xk(:,1) / ( xk(:,1) + rad%extkd(:) )& !!$ + C%GAUSS_W(2) xk(:,2) / ( xk(:,2) + rad%extkd(:) )& !!$ + C%GAUSS_W(3) xk(:,3) / ( xk(:,3) + rad%extkd(:) ) ) !! Ticket (vh) !! the above line is incorrect, as it is missing a factor of 2 in the numerator. !! (See equation 6.21 from Goudriaan & van Laar 1994) !! The correct version below doubles canopy reflectance for diffuse radiation. !! (Note it is correctly implemented in the evaluation of canopy beam reflectance !! rad%rhocbm in canopy_albedo.F90).

 rad%rhocdf(:,ictr) = rhoch(:,ictr) *                                      &
                      ( C%GAUSS_W(1) * 2. *xk(:,1) / ( xk(:,1) + rad%extkd(:) )&
                      + C%GAUSS_W(2) * 2. *xk(:,2) / ( xk(:,2) + rad%extkd(:) )&
                      + C%GAUSS_W(3) * 2. *xk(:,3) / ( xk(:,3) + rad%extkd(:) ) )

ENDDO

Issue migrated from trac:147 at 2023-11-27 11:20:45 +1100

penguian commented 7 years ago

@jxs599@nci.org.au changed status from new to closed

penguian commented 7 years ago

@jxs599@nci.org.au changed resolution from ` tofixed`

penguian commented 7 years ago

@jxs599@nci.org.au changed milestone from 3. Implementation to 1. Closed

penguian commented 7 years ago

@jxs599@nci.org.au commented

already part of the Quasi-CMIP6 trunk

pushed updated PFT parameters for albedo as well.

penguian commented 6 years ago

@jxs599@nci.org.au commented

removed common factor of two

CABLE-TRAC (interim trunk)

Changeset: -5a54faa8245f231a6d17024cc4e1ac555f0b2cab

penguian commented 1 year ago

@ccc561@nci.org.au changed keywords from albedo, diffuse radiation to albedo, diffuse radiation nogit