Open penguian opened 7 years ago
@jxs599@nci.org.au changed status from new
to assigned
@jxs599@nci.org.au edited the issue description
@jxs599@nci.org.au edited the issue description
@jxs599@nci.org.au edited the issue description
@jxs599@nci.org.au changed milestone from 6. Report
to 5. Validation
@ccc561@nci.org.au set keywords to keepgit
keyword_keepgit
owner:jxs599@nci.org.au
type_defect
| by srb001@csiro.auThis effectively means that core code should not have any dependencies in application driver code. An example of this is dependency in cable_climate on USE cable_io_vars_module to access "patch".
Can skirt this by simply building with this access enabled as is done in the trunk currently.
In UM10.6 implementation this is avoided by extending the fpp pre-processor exclusions to surround this as well.
As this only applies in terms of IF( patch% lat/long) we can use lat/long as garnered from UM. Question then is how to, or how to avoid differentiating between applications and using with patch% or UM derived lat/long. Could use cable_runtime%um then USE lat/long or patch. But doesn't work in header USE cable_io_vars, ONLY : patch. Maybe make "patch%" a core type avail to everyone and move declaration thereof into cable_common?
This is also evident through trying to build UM10.6 version. Identified:
cable_phenology USEs cabe_io_vars
CMIP6 modifications have also introduced cable_iovars dependency in cable_canopy
Issue migrated from trac:149 at 2023-11-27 11:20:59 +1100