search

CABLE-LSM / CABLE-Trac-archive

Archive CABLE Trac contents as issues
Other
0 stars 0 forks source link

code clean up in soilsnow module #169

Open penguian opened 6 years ago

penguian commented 6 years ago

keyword_maygit owner:jxs599@nci.org.au type_code improvement | by bep599

In subroutine soil_snow within the soilsnow module (1e8c5f9b03cc5180f74758b6a87d379fefaa7cda), there is a section of code for offline runs to get rid of crazy initial conditions when ktau_gl=1, i.e. first time step. At the end of this section, there is the calculation of ssnow%gammzz(:,1) (lines 1785-1789). Right after this section, the same variable ssnow%gammzz(:,1) is being calculated again, but with an additional component.

From the flow of the code, the first calculation has become redundant and can be removed. However, the expert in this area should confirm if the second equation (i.e. with the additional component) is the correct one.

Issue migrated from trac:169 at 2023-11-27 11:23:09 +1100

penguian commented 5 years ago

@jxs599@nci.org.au changed milestone from ` to6. Report`

penguian commented 5 years ago

@jxs599@nci.org.au changed status from new to assigned

penguian commented 5 years ago

@jxs599@nci.org.au changed owner from somebody to jxs599

penguian commented 5 years ago

@jxs599@nci.org.au commented

general clean up of the code as it goes into JaC .

Issue raised in description above needs to be resolved.

penguian commented 1 year ago

@ccc561@nci.org.au set keywords to maygit