search

CABLE-LSM / CABLE-Trac-archive

Archive CABLE Trac contents as issues
Other
0 stars 0 forks source link

update to cls package (#137) #170

Open penguian opened 6 years ago

penguian commented 6 years ago

keyword_keepgit type_defect | by inh599

As noted in the code set linked to Ticket 137, the snow_accum routine (in the cable_soilsnow module) permits both energy and moisture conservation to be violated if there isn't sufficient snow cover to permit the diagnosed latent heat flux over the time step (the final WHERE condition in snow_accum). This is because while %evapsn is limited, %fess is not.

To fix this issue: within, and at the end of, the final WHERE (ssnow%cls=1.1335) [or original WHERE(ssnow%snowd > 0.1) ] condition we need to include

WHERE (xxx .ne. ssnow%evapsn) canopy%fess = canopy%fess - (xxx - ssnow%evapsn)(C%HL + C%HLF) / dels canopy%fhs = canopy%fhs + (xxx - ssnow%evapsn)(C%HL + C%HLF) / dels ENDWHERE

This will restrict the snow latent heat flux and pass the associated energy increment onto the sensible heat flux (thereby conserving both energy and moisture).

Issue migrated from trac:170 at 2023-11-27 11:23:15 +1100

penguian commented 6 years ago

@jxs599@nci.org.au changed milestone from 6. Report to 4. Low Priority

penguian commented 6 years ago

@jxs599@nci.org.au commented

I remember working on this but cant find it at the moment

penguian commented 2 years ago

@jxs599@nci.org.au commented

Surely this was done for CMIP6?

penguian commented 1 year ago

@ccc561@nci.org.au set keywords to keepgit