Restart file names not consistent and hard-coded

[penguian]

keyword_nogit owner:vxh599@nci.org.au resolution_fixed type_code improvement | by amu561

---

In subroutine WRITE_CASA_RESTART_NC, the restart file name is hard-coded and can only be partly modified through the namelist by changing the RunIden:

fname = TRIM(filename%path)_'/'_TRIM( cable_user%RunIden )//& '_casa_rst.nc'

This convention does not match the subroutine READ_CASA_RESTART_NC, where the code first looks for casafile%cnpipool, which can be passed through the namelist:

fname = TRIM(casafile%cnpipool)

Suggest removing hard-coded file names and passing CASA-CNP restart_in file through casafile%cnpipool and restart_out file through casafile%cnpepool so these can be fully user-defined through the namelist.

---

Issue migrated from trac:173 at 2023-11-27 11:23:37 +1100

[penguian]

@vxh599@nci.org.au changed status from new to assigned

[penguian]

@vxh599@nci.org.au changed owner from yxw599 to vxh599

[penguian]

@vxh599@nci.org.au commented

---

Suggest disabling casa_poolout subroutine in casa_inout.F90, which writes pools to casafile%cnpepool.

In casa_inout.F90, write_casarst subroutine has been modified to use casafile%cnpepool if string length is greater than zero, otherwise default name: IF (length( TRIM(casafile%cnpepool) ) .gt. 0) THEN fname=TRIM(casafile%cnpepool) ELSE fname = TRIM(filename%path)'/'_TRIM( cable_user%RunIden )//& '_casa_rst.nc' ENDIF

Changes are in https://trac.nci.org.au/svn/cable/branches/Users/vxh599/CMIP6-bios3 at revision 5003.

[penguian]

@yxw599@nci.org.au changed status from assigned to closed

[penguian]

@yxw599@nci.org.au changed resolution from ` tofixed`

[penguian]

@yxw599@nci.org.au commented

---

This change of filename was made by some one else (I do not use any TRIM function in my coding), so are some other changes of CASA codes. I was never given the opportunity to review those changes before they were made into the trunk.

Here is my recommendation: get the filename from the namelist file as I originally did.

[penguian]

@jxs599@nci.org.au changed status from closed to reopened

[penguian]

@jxs599@nci.org.au changed resolution from fixed to ``

[penguian]

@jxs599@nci.org.au changed milestone from ` to3. Implementation`

[penguian]

@jxs599@nci.org.au changed status from reopened to closed

[penguian]

@jxs599@nci.org.au changed resolution from ` tofixed`

[penguian]

@jxs599@nci.org.au changed milestone from 3. Implementation to 1. Closed

[penguian]

@ccc561@nci.org.au set keywords to nogit