search

CABLE-LSM / CABLE-Trac-archive

Archive CABLE Trac contents as issues
Other
0 stars 0 forks source link

Definition of number of soil types [mstype] #244

Closed penguian closed 2 years ago

penguian commented 4 years ago

keyword_nogit owner:jxs599@nci.org.au resolution_wontfix type_JAC readiness | by srb001@csiro.au

In JAC definition of mstype should occur through a namelist.

Offline mstype is declared and USEd through cable_define_types. It was being defined reading the text file defining soil type parameters. During development of CM2 this was migrated to cable_soil_params.F90 (This has also been the case offline since Feb, 2019), where declaration also defines to default values which are actually those in the file anyway.

JULES can't allow an embedded routine so far down the chain to speak to the outside world. It's wrong for several reasons. It should be read at the toplevel, and preferably thru a namelist.

The existing mechanism most suitable in JAC is thru cable_soilparm.nml. In JAC we already have declarations of these so can 1. maneuver cable_soil_params.F90 to offline only and in that routine add a namelist reader. Ultimately make offline case as close to JAC case.

At present in HAC5.7, whilst soil params are read in correctly thru a namelist, 2. we need to add mstype.

THIS mstype needs to be the one USEd in the code. A list of instances of mstype uses in CABLE is here. 3. Slowly dissolve cable_define_types by migrating "things" to alternate files/modules. So that we know we are picking up this new version.

Issue migrated from trac:244 at 2023-11-27 11:31:44 +1100

penguian commented 4 years ago

@jxs599@nci.org.au changed status from new to assigned

penguian commented 4 years ago

@jxs599@nci.org.au changed type from defect to JAC readiness

penguian commented 4 years ago

@jxs599@nci.org.au set milestone to 3. Implementation

penguian commented 4 years ago

@jxs599@nci.org.au commented

JAC uses a file called cable_types_mod that at present contains way too many things. I suggest this be further broken down into a model grid dec/def file, params, etc. Firstly though use just this file and get this working reproducibly.

penguian commented 4 years ago

@jxs599@nci.org.au edited the issue description

penguian commented 2 years ago

@jxs599@nci.org.au changed status from assigned to closed

penguian commented 2 years ago

@jxs599@nci.org.au set resolution to wontfix

penguian commented 2 years ago

@jxs599@nci.org.au changed milestone from 3. Implementation to 1. Closed

penguian commented 2 years ago

@jxs599@nci.org.au commented

discussions seem to have landed on maintaining this hard-wired number as changing it through nameless will be bad unless the provided IO matches and then code is set up to deal with certain number of soil types, layers, PFTs etc anyway

penguian commented 1 year ago

@ccc561@nci.org.au set keywords to nogit