search

CABLE-LSM / CABLE-Trac-archive

Archive CABLE Trac contents as issues
Other
0 stars 0 forks source link

CASA analytical spinup logic is incorrect #248

Closed penguian closed 1 year ago

penguian commented 4 years ago

keyword_nogit owner:yxw599@nci.org.au resolution_fixed type_defect | by mgk576

In spincascnp.F90, the logic to average each of the terms to solve the steady state is broadly as follows:

avg_cleaf2met = avg_cleaf2met/REAL(nday*myearspin)

But this is incorrect as nday # all the days of the simulations and then this is being multiplied by the number of years! This was clearly a mistake when this code was ported and nday 365 (I would guess). As written, the analytical solution simply does not work. It should have been

avg_cleaf2met = avg_cleaf2met/REAL(nday)

I have fixed it in:

https://trac.nci.org.au/trac/cable/browser/branches/Users/mgk576/trunk_analytical

I've consulted with Ying-Ping and he agrees.

See related ticket: https://trac.nci.org.au/trac/cable/ticket/242

Issue migrated from trac:248 at 2023-11-27 11:32:12 +1100

penguian commented 1 year ago

@ccc561@nci.org.au set milestone to 1. Closed

penguian commented 1 year ago

@ccc561@nci.org.au commented

This was solved when #242 was merged in trunk

penguian commented 1 year ago

@jxs599@nci.org.au changed status from new to closed

penguian commented 1 year ago

@jxs599@nci.org.au set resolution to fixed

penguian commented 1 year ago

@jxs599@nci.org.au commented

Thanks Claire. I'll take your word for it :) that it went in with #242

penguian commented 1 year ago

@ccc561@nci.org.au set keywords to nogit