search

CABLE-LSM / CABLE-Trac-archive

Archive CABLE Trac contents as issues
Other
0 stars 0 forks source link

use consistent tolerance for radiation threshold #258

Closed penguian closed 1 year ago

penguian commented 3 years ago

keyword_keepgit resolution_fixed type_model improvement | by srb001@csiro.au

coszen_tols is used to define sunlit mask - at least in cable um_init_subrs rad_thresh needs to be replaced with same. Check elsewhere

Issue migrated from trac:258 at 2023-11-27 11:33:29 +1100

penguian commented 1 year ago

@ccc561@nci.org.au commented

Looking at the trunk, this seems to have been done except I don't understand what is happening between the definition of fsunlit_mask and where it is called in offline/cbl_model_driver_offline.F90.

There is no error but the dummy arguments are coszen_tols and coszen while the actual arguments are RAD_THRESH and fsd. This seems quite confusing. Since the function is only called once, why not change the names of the dummy arguments?

I fully realise this is in JaC so it's not urgent, just pointing this out for consistency.

penguian commented 1 year ago

@ccc561@nci.org.au changed _comment0 which not transferred by tractive

penguian commented 1 year ago

@jxs599@nci.org.au changed status from new to closed

penguian commented 1 year ago

@jxs599@nci.org.au set resolution to fixed

penguian commented 1 year ago

@jxs599@nci.org.au changed milestone from 6. Report to 1. Closed

penguian commented 1 year ago

@jxs599@nci.org.au commented

Also #264 - this has all been taken care of and is now part of Bothe JULES@vn7.1 and CABLE@.......f7fb6d286e9dfa0fc5f98243eb55a19d99da2134(following #360)

penguian commented 1 year ago

@ccc561@nci.org.au set keywords to keepgit