search

CABLE-LSM / CABLE-Trac-archive

Archive CABLE Trac contents as issues
Other
0 stars 0 forks source link

Initializing masks used in CABLE (cbl_masks.F90) #264

Closed penguian closed 1 year ago

penguian commented 4 years ago

keyword_nogit owner:jxs599@nci.org.au resolution_fixed type_model improvement | by srb001@csiro.au

Achieved on radiation pathway - however is expected in ALL cases to define masks at "update" stage defining fundamental masks used by CABLE to choose how to proceed with calculations at a grid point: Is the grid point: vegetated? sunlit? both?

In JAC, the surface albedo is required before CABLE has more generally been initialized. HOWEVER, CABLE does not require initialization beyond a few veg and soil parameters - So long as we move to accessing whether a cell is sunlit or not given the zenith angle (as opposed to using the downwards SW - forcing which has not and cannot be calculated until this mask is defied). So given this circular dependency which must be rectified it makes sense to pull this calc out which is calculated in a dozen places throughout CABLE, and do it once, at the start.

Issue migrated from trac:264 at 2023-11-27 11:34:08 +1100

penguian commented 1 year ago

@ccc561@nci.org.au commented

To close?

penguian commented 1 year ago

@ccc561@nci.org.au commented

Duplicate of #258?

penguian commented 1 year ago

@jxs599@nci.org.au changed status from new to closed

penguian commented 1 year ago

@jxs599@nci.org.au set resolution to fixed

penguian commented 1 year ago

@jxs599@nci.org.au changed milestone from 6. Report to 1. Closed

penguian commented 1 year ago

@jxs599@nci.org.au commented

Also #258 - this has all been taken care of and is now part of Bothe JULES@vn7.1 and CABLE@.......f7fb6d286e9dfa0fc5f98243eb55a19d99da2134(following #360)

penguian commented 1 year ago

@ccc561@nci.org.au set keywords to nogit