Improving cable_radiation.F90

[penguian]

keyword_nogit owner:jxs599@nci.org.au type_model improvement | by srb001@csiro.au

---

cable_radiation.F90: : cbl_init_radiation.F90 : cbl_radiation.F90 : cbl_rhoch.F90 : cbl_sinbet.F90 : cbl_spitter.F90

In JAC, the surface albedo is required before CABLE has more generally been initialized. Closer inspection shows that we can compute the surface albedo given only a few veg and soil parameters - So long as we move to accessing whether a cell is sunlit or not given the zenith angle rather than downward SW, which in a circular fashion precluding calculation of the surface albedo has not yet been determined, requiring surface albedo in its determination. Closer inspection also reveals that this pathway to get the surface albedo is very un-neccessarily convoluted and hard to follow with non-descriptive varible names and a haphazzard order of operation. See Ticket #267 as well

The first step to achieving the ultimate goal of calcculating the surface albedo as efficiently as possible will be to unclutter the existing radiation_module as it is required by "albedo" code; by first separating the single cable_radiation.F90 into subroutines per pe modules, files.

The "init_radiation" routine in particular is re-written to carify what is actually needed and when.

---

Issue migrated from trac:267 at 2023-11-27 11:34:31 +1100

[penguian]

@ccc561@nci.org.au commented

---

Close?

[penguian]

@ccc561@nci.org.au set keywords to nogit