Trunk patchfrac fix - Githubissues

penguian commented 3 years ago

keyword_nogit owner:jxs599@nci.org.au resolution_fixed type_defect | by mgk576

The implemented fix to the trunk for multiple patches does not work. I think the old ticket was -> https://trac.nci.org.au/trac/cable/ticket/199

In cable_parameters.F90

ELSE
      !loop through lat and lon to fill patch and veg vars
      DO lon = 1,nlon
        DO lat = 1, nlat
          inPFrac(lon,lat,1) = vegpatch_metfile(1,1) !Anna: passing met patchfrac here
          inPFrac(lon,lat,2) = vegpatch_metfile(1,2) !Anna: passing met patchfrac here
          inPFrac(lon,lat,3) = vegpatch_metfile(1,3) !Anna: passing met patchfrac here
          inPFrac(lon,lat,4) = vegpatch_metfile(1,4) !Anna: passing met patchfrac here
          inVeg(lon,lat,:) = vegtype_metfile(1,:)
        ENDDO
      ENDDO
    END IF

should be:

ELSE
      !loop through lat and lon to fill patch and veg vars
      DO lon = 1,nlon
        DO lat = 1, nlat
          !inPFrac(lon,lat,1) = vegpatch_metfile(1,1) !Anna: passing met patchfrac here
          !inPFrac(lon,lat,2) = vegpatch_metfile(1,2) !Anna: passing met patchfrac here
          !inPFrac(lon,lat,3) = vegpatch_metfile(1,3) !Anna: passing met patchfrac here
          !inPFrac(lon,lat,4) = vegpatch_metfile(1,4) !Anna: passing met patchfrac here

          !Above code shouldn't be there... Anna 2nd Feb 2020
          inPFrac(lon,lat,:) = vegpatch_metfile(1,:) !Anna: passing met patchfrac here
          inVeg(lon,lat,:) = vegtype_metfile(1,:)
        ENDDO
      ENDDO
    END IF

Issue migrated from trac:276 at 2023-11-27 11:35:23 +1100

penguian commented 3 years ago

@jxs599@nci.org.au changed status from new to closed

penguian commented 3 years ago

@jxs599@nci.org.au set resolution to fixed

penguian commented 3 years ago

@jxs599@nci.org.au set milestone to 1. Closed

penguian commented 1 year ago

@ccc561@nci.org.au set keywords to nogit

CABLE-LSM / CABLE-Trac-archive

Trunk patchfrac fix #276