search

CABLE-LSM / CABLE-Trac-archive

Archive CABLE Trac contents as issues
Other
0 stars 0 forks source link

Restart_out file path changes internally within CABLE #278

Closed penguian closed 2 years ago

penguian commented 3 years ago

keyword_nogit owner:jxs599@nci.org.au resolution_fixed type_defect | by amu561

Instead of passing the full restart_out file name and path through the namelist option "filename%restart_out", CABLE uses an extra "filename%path" argument to modify the file path internally.

In cable_output.F90:

IF ( TRIM(filename%path) .EQ. '' ) filename%path = './'
   frst_out = TRIM(filename%path)_'/'_TRIM(filename%restart_out)

Filename%path should not be used internally to modify file names provided in the namelist. The need to set this additional path is not at all obvious to the user and causes issues when the user does not want to use a relative path.

Suggest removing this hard-coded path so filename%restart_out sets the entire file name and path:

IF ( TRIM(filename%path) .EQ. '' ) filename%path = './'

Issue migrated from trac:278 at 2023-11-27 11:35:35 +1100

penguian commented 2 years ago

@jxs599@nci.org.au changed status from new to closed

penguian commented 2 years ago

@jxs599@nci.org.au set resolution to fixed

penguian commented 2 years ago

@jxs599@nci.org.au set milestone to 1. Closed

penguian commented 2 years ago

@jxs599@nci.org.au commented

pushed at 0535ae688bfac226cee7a6ac8b2120be1d1c3f1e

penguian commented 1 year ago

@ccc561@nci.org.au set keywords to nogit