search

CABLE-LSM / CABLE-Trac-archive

Archive CABLE Trac contents as issues
Other
0 stars 0 forks source link

casa-cnp (bug2021h) #289

Closed penguian closed 3 years ago

penguian commented 3 years ago

keyword_nogit owner:jxs599@nci.org.au resolution_fixed type_defect | by yxw599

for changes, check https://trac.nci.org.au/svn/cable/branches/Users/yxw599/cable-3.0_beta/ revision: 8056

Issue: calculate P required using P:C ratio as in ACCESS ESM1.5, not N:P ratio.

< 2174a2047,2074

      Preqmax(np,leaf) = xpCnpp(np)* casaflux%fracCalloc(np,leaf) &
           * (casapool%Nplant(np,leaf)/(casapool%Cplant(np,leaf)+1.0e-10))/casabiome%ratioNPplantmin(veg%iveg(np),leaf)
      Preqmax(np,wood) = xpCnpp(np)* casaflux%fracCalloc(np,wood) &
           * (casapool%Nplant(np,wood)/(casapool%Cplant(np,wood)+1.0e-10))/casabiome%ratioNPplantmin(veg%iveg(np),wood)
      Preqmax(np,froot) = xpCnpp(np)* casaflux%fracCalloc(np,froot) &
           * (casapool%Nplant(np,froot)/(casapool%Cplant(np,froot)+1.0e-10))/casabiome%ratioNPplantmin(veg%iveg(np),froot)

      Preqmin(np,leaf) = xpCnpp(np) * casaflux%fracCalloc(np,leaf) &
           * (casapool%Nplant(np,leaf)/(casapool%Cplant(np,leaf)+1.0e-10))/casabiome%ratioNPplantmax(veg%iveg(np),leaf)
      Preqmin(np,wood) = xpCnpp(np) * casaflux%fracCalloc(np,wood) &
           * (casapool%Nplant(np,wood)/(casapool%Cplant(np,wood)+1.0e-10))/casabiome%ratioNPplantmax(veg%iveg(np),wood)
      Preqmin(np,froot) = xpCnpp(np) * casaflux%fracCalloc(np,froot) &
           * (casapool%Nplant(np,froot)/(casapool%Cplant(np,froot)+1.0e-10))/casabiome%ratioNPplantmax(veg%iveg(np),froot)

      PtransPtoP(np,leaf) = casaflux%kplant(np,leaf)*casapool%Pplant(np,leaf) &
           * (1.0-casabiome%ftransPPtoL(veg%iveg(np),leaf))
      PtransPtoP(np,wood) = casaflux%kplant(np,wood)*casapool%Pplant(np,wood) &
           * (1.0-casabiome%ftransPPtoL(veg%iveg(np),wood))
      PtransPtoP(np,froot) = casaflux%kplant(np,froot)*casapool%Pplant(np,froot) &
           * (1.0-casabiome%ftransPPtoL(veg%iveg(np),froot))

      Preqmax(np,leaf)    = MAX(0.0,Preqmax(np,leaf) - PtransPtoP(np,leaf))
      Preqmax(np,wood)    = MAX(0.0,Preqmax(np,wood) - PtransPtoP(np,wood))
      Preqmax(np,froot)    = MAX(0.0,Preqmax(np,froot) - PtransPtoP(np,froot))

      Preqmin(np,leaf)    = MAX(0.0,Preqmin(np,leaf) - PtransPtoP(np,leaf))
      Preqmin(np,wood)    = MAX(0.0,Preqmin(np,wood) - PtransPtoP(np,wood))
      Preqmin(np,froot)    = MAX(0.0,Preqmin(np,froot) - PtransPtoP(np,froot))

2176,2203d2075 < Preqmax(np,leaf) = xpCnpp(np) casaflux%fracCalloc(np,leaf) & < casabiome%ratioPCplantmax(veg%iveg(np),leaf) < Preqmax(np,wood) = xpCnpp(np) casaflux%fracCalloc(np,wood) & < casabiome%ratioPCplantmax(veg%iveg(np),wood) < Preqmax(np,froot) = xpCnpp(np) casaflux%fracCalloc(np,froot) & < casabiome%ratioPCplantmax(veg%iveg(np),froot) < < Preqmin(np,leaf) = xpCnpp(np) casaflux%fracCalloc(np,leaf) & < casabiome%ratioPCplantmin(veg%iveg(np),leaf) < Preqmin(np,wood) = xpCnpp(np) casaflux%fracCalloc(np,wood) & < casabiome%ratioPCplantmin(veg%iveg(np),wood) < Preqmin(np,froot) = xpCnpp(np) casaflux%fracCalloc(np,froot) & < casabiome%ratioPCplantmin(veg%iveg(np),froot) < < PtransPtoP(np,leaf) = casaflux%kplant(np,leaf)casapool%Pplant(np,leaf) & < (1.0-casabiome%ftransPPtoL(veg%iveg(np),leaf)) < PtransPtoP(np,wood) = casaflux%kplant(np,wood)casapool%Pplant(np,wood) & < (1.0-casabiome%ftransPPtoL(veg%iveg(np),wood)) < PtransPtoP(np,froot) = casaflux%kplant(np,froot)casapool%Pplant(np,froot) & < (1.0-casabiome%ftransPPtoL(veg%iveg(np),froot)) < < Preqmax(np,leaf) = max(0.0,Preqmax(np,leaf) - PtransPtoP(np,leaf)) < Preqmax(np,wood) = max(0.0,Preqmax(np,wood) - PtransPtoP(np,wood)) < Preqmax(np,froot) = max(0.0,Preqmax(np,froot)- PtransPtoP(np,froot)) < < Preqmin(np,leaf) = max(0.0,Preqmin(np,leaf) - PtransPtoP(np,leaf)) < Preqmin(np,wood) = max(0.0,Preqmin(np,wood) - PtransPtoP(np,wood)) < Preqmin(np,froot) = max(0.0,Preqmin(np,froot)- PtransPtoP(np,froot)) 2205c2077 < IF(casapool%pplant(np,leaf)/(casapool%cplant(np,leaf)+1.0e-10)> casabiome%ratioPCplantmax(veg%iveg(np),leaf)) THEN

      IF(casapool%pplant(np,leaf)/(casapool%nplant(np,leaf)+1.0e-10)> 1.0/casabiome%ratioNPplantmin(veg%iveg(np),leaf)) THEN

2209c2081 < IF(casapool%pplant(np,wood)/(casapool%cplant(np,wood)+1.0e-10)> casabiome%ratioPCplantmax(veg%iveg(np),wood)) THEN

      IF(casapool%pplant(np,wood)/(casapool%nplant(np,wood)+1.0e-10)> 1.0/casabiome%ratioNPplantmin(veg%iveg(np),wood)) THEN

2213c2085 < IF(casapool%pplant(np,froot)/(casapool%cplant(np,froot)+1.0e-10)> casabiome%ratioPCplantmin(veg%iveg(np),froot)) THEN

      IF(casapool%pplant(np,froot)/(casapool%nplant(np,froot)+1.0e-10)> 1.0/casabiome%ratioNPplantmin(veg%iveg(np),froot)) THEN

Issue migrated from trac:289 at 2023-11-27 11:36:50 +1100

penguian commented 3 years ago

@jxs599@nci.org.au set milestone to 1. Closed

penguian commented 3 years ago

@jxs599@nci.org.au commented

Merged into tagged CABLE-3.0 beta

penguian commented 3 years ago

@jxs599@nci.org.au changed status from new to closed

penguian commented 3 years ago

@jxs599@nci.org.au set resolution to fixed

penguian commented 3 years ago

@jxs599@nci.org.au commented

Merged into tagged CABLE-3.0 beta

penguian commented 1 year ago

@ccc561@nci.org.au set keywords to nogit