casa-cnp (bug 2021i)

[penguian]

keyword_nogit owner:jxs599@nci.org.au resolution_fixed type_defect | by yxw599

---

N and P pools are not initialized correctly when icycle=1 or 2 in casa_ndummy and casa_pdummy

check

https://trac.nci.org.au/svn/cable/branches/Users/yxw599/cable-3.0_beta/ revision: 8056

2594,2608c2382,2386 < SUBROUTINE casa_ndummy(casamet,casabal,casapool) < IMPLICIT NONE < TYPE (casa_met), INTENT(IN) :: casamet < TYPE (casa_balance), INTENT(INOUT) :: casabal < TYPE (casa_pool), INTENT(INOUT) :: casapool < < casapool%Nplant(:,:) = casapool%ratioNCplant(:,:) casapool%cplant(:,:) < casapool%Nlitter(:,:)= casapool%ratioNClitter(:,:) casapool%clitter(:,:) < casapool%Nsoil(:,:) = casapool%ratioNCsoil(:,:) * casapool%Csoil(:,:) < casapool%nsoilmin(:) = 2.0 < casabal%sumnbal(:) = 0.0 < WHERE(casamet%iveg2==grass) < casapool%nplant(:,wood) = 0.0 < casapool%nlitter(:,cwd) = 0.0 < ENDWHERE

SUBROUTINE casa_ndummy(casapool) IMPLICIT NONE TYPE (casa_pool), INTENT(INOUT) :: casapool

casapool%Nplant(:,:) = casapool%Cplant(:,:) * casapool%ratioNCplant(:,:)

2610c2388 < END SUBROUTINE casa_ndummy

END SUBROUTINE casa_ndummy 2612c2390 < SUBROUTINE casa_pdummy(casamet,casabal,casaflux,casapool)

SUBROUTINE casa_pdummy(casapool) 2614,2616d2391 < TYPE (casa_met), INTENT(IN) :: casamet < TYPE (casa_balance), INTENT(INOUT) :: casabal < TYPE (casa_flux), INTENT(IN) :: casaflux 2618,2667d2392 < ! ypw: the following data block should be consistent with "casa_poolout" < ! local variables < REAL(r_2), DIMENSION(mso) :: Psorder,pweasoil,xpsoil50 < REAL(r_2), DIMENSION(mso) :: fracPlab,fracPsorb,fracPocc,fracPorg < REAL(r_2), DIMENSION(mp) :: totpsoil < INTEGER npt,nout,nso < < ! Soiltype soilnumber soil P(g P/m2) < ! Alfisol 1 61.3 < ! Andisol 2 103.9 < ! Aridisol 3 92.8 < ! Entisol 4 136.9 < ! Gellisol 5 98.2 < ! Histosol 6 107.6 < ! Inceptisol 7 84.1 < ! Mollisol 8 110.1 < ! Oxisol 9 35.4 < ! Spodosol 10 41.0 < ! Ultisol 11 51.5 < ! Vertisol 12 190.6 < < DATA psorder/61.3,103.9,92.8,136.9,98.2,107.6,84.1,110.1,35.4,41.0,51.5,190.6/ < DATA pweasoil/0.05,0.04,0.03,0.02,0.01,0.009,0.008,0.007,0.006,0.005,0.004,0.003/ < DATA fracpLab/0.08,0.08,0.10,0.02,0.08,0.08,0.08,0.06,0.02,0.05,0.09,0.05/ < DATA fracPsorb/0.32,0.37,0.57,0.67,0.37,0.37,0.37,0.32,0.24,0.22,0.21,0.38/ < DATA fracPocc/0.36,0.38,0.25,0.26,0.38,0.38,0.38,0.44,0.38,0.38,0.37,0.45/ < DATA fracPorg/0.25,0.17,0.08,0.05,0.17,0.17,0.17,0.18,0.36,0.35,0.34,0.12/ < DATA xpsoil50/7.6,4.1,4.2,3.4,4.1,4.1,4.8,4.1,6.9,6.9,6.9,1.7/ < < < totpsoil(:) = psorder(casamet%isorder(:)) xpsoil50(casamet%isorder(:)) < casabal%sumpbal(:) = 0.0 < ! casapool%pplant(:,:) = casapool%Nplant(:,:)/casapool%ratioNPplant(:,:) < ! casapool%plitter(:,:) = casapool%Nlitter(:,:)/(casapool%ratioNPlitter(:,:)+1.0e-10) < ! casapool%psoil(:,:) = casapool%Nsoil(:,:)/casapool%ratioNPsoil(:,:) < casapool%pplant(:,:) = casapool%Cplant(:,:) casapool%ratioPcplant(:,:) < casapool%plitter(:,:) = casapool%Clitter(:,:) casapool%ratioPclitter(:,:) < casapool%psoil(:,:) = casapool%Csoil(:,:) casapool%ratioPcsoil(:,:) < < ! casapool%psoillab(:) = totpsoil(:) fracpLab(casamet%isorder(:)) < < ! casapool%psoilsorb(:) = casaflux%psorbmax(:) casapool%psoillab(:) & < ! /(casaflux%kmlabp(:)+casapool%psoillab(:)) < < ! casapool%psoilocc(:) = totpsoil(:) *fracPocc(casamet%isorder(:)) < < < WHERE(casamet%iveg2==grass) < casapool%pplant(:,wood) = 0.0 < casapool%plitter(:,cwd) = 0.0 < ENDWHERE 2669c2394,2396 < END SUBROUTINE casa_pdummy

casapool%Pplant(:,:) = casapool%Nplant(:,:) / casapool%ratioNPplant(:,:)

END SUBROUTINE casa_pdummy

---

Issue migrated from trac:290 at 2023-11-27 11:36:57 +1100

[penguian]

@jxs599@nci.org.au changed status from new to closed

[penguian]

@jxs599@nci.org.au set resolution to fixed

[penguian]

@jxs599@nci.org.au set milestone to 1. Closed

[penguian]

@jxs599@nci.org.au commented

---

Merged into tagged CABLE-3.0 beta

[penguian]

@ccc561@nci.org.au set keywords to nogit