search

CABLE-LSM / CABLE-Trac-archive

Archive CABLE Trac contents as issues
Other
0 stars 0 forks source link

cable_roughness ESM1.5 #310

Closed penguian closed 3 years ago

penguian commented 3 years ago

keyword_keepgit owner:jxs599@nci.org.au resolution_fixed type_defect | by srb001@csiro.au

Porting CABLE3 to ESM1.5 an issue was faced including the modified reference height calculation as discussed in Ticket #148.

cable_roughness for CABLE3 has replaced the massive and nested WHERE loop with a DO loop. Under the IF vegetated condition this calc of reference height (zref) appears on both sides. Porting and debugging suggested the problem was with Zref, however debugging with WHERE loops is difficult/impossible (One very good reason to get rid of them.) Not being able to untangle this we adopted a solution of introducing a ESM1.5 runtime switch that forces using the old method of calculating zref. Of course there were "bugs" further down the line which also made this method more suited.

Now, that the model appears stable it is certainly possible that revisisting this issue will reveal that so long as consistency is maintained across the "IF vegetated condition" the new calc of reference height can be used.

However, ATM, this is of lower priority than getting the CASA code updated etc etc.

Issue migrated from trac:310 at 2023-11-27 11:39:09 +1100

penguian commented 3 years ago

@jxs599@nci.org.au changed status from new to closed

penguian commented 3 years ago

@jxs599@nci.org.au set resolution to fixed

penguian commented 3 years ago

@jxs599@nci.org.au changed component from JAC readiness to UM

penguian commented 3 years ago

@jxs599@nci.org.au set milestone to 1. Closed

penguian commented 3 years ago

@jxs599@nci.org.au commented

pushed to trunk @[8501]

penguian commented 1 year ago

@ccc561@nci.org.au set keywords to keepgit