search

CABLE-LSM / CABLE-Trac-archive

Archive CABLE Trac contents as issues
Other
0 stars 0 forks source link

avoid passing vegin/soilin in JAC #313

Closed penguian closed 2 years ago

penguian commented 2 years ago

keyword_nogit owner:jxs599@nci.org.au resolution_invalid type_JAC readiness | by srb001@csiro.au

We can avoid sending vegin/soilin to JAC interface BUT needs some modifying:

vegin is the easy one. The only instance of vegin is in initialisation here: which can be modified to use veg%.

SUBROUTINE init_bgc_vars() .... bgc%cplant(:,k) = vegin%cplant(k,veg%iveg)

soilin values are really only going to matter for global runs.

soilin(9) [ICE] values are used, otherwise everything is mapped from existing spatial JULES vars. EXCEPT for rhosoil which assumes soilin(2) as there is no corresponding JULES var. rhosoil is only ever used in the same product for which there IS a JULES var. I suggest we modify the code to use this.

Issue migrated from trac:313 at 2023-11-27 11:39:27 +1100

penguian commented 2 years ago

@jxs599@nci.org.au commented

This has also been revised. We have decided to SEND vegin/soilin to CABLE/interface and map it to "MP" there (potentially every timestep/pathway).

penguian commented 2 years ago

@jxs599@nci.org.au changed status from new to closed

penguian commented 2 years ago

@jxs599@nci.org.au set resolution to invalid

penguian commented 2 years ago

@jxs599@nci.org.au changed milestone from 6. Report to 1. Closed

penguian commented 1 year ago

@ccc561@nci.org.au set keywords to nogit