search

CABLE-LSM / CABLE-Trac-archive

Archive CABLE Trac contents as issues
Other
0 stars 0 forks source link

re-intstate runtime = offline flag #317

Closed penguian closed 2 years ago

penguian commented 2 years ago

keyword_cable_runtime_%_offline keyword_initialisation keyword_snow_%_t_snwlr_maygit resolution_fixed type_defect | by srb001@csiro.au

In testing CABLE3@Loobos and reconciling that using JULES offline vs CABLE offline as "driving" code, the cable_runttime%offline switch became problematic.

It would seem however that the only instance of this causing a problem was in the initialisation of snow%t_snwlr, which was behind this switch. We hid the IF(cable_runttime%offline) condition, allowing this initialisation to proceed in all cases, HOWEVER we also somehow deleted the cable_runtime%offline=.TRUE. switch in cable_driver().

The initialisation of snow%t_snwlr seems to be the only place where this is having an effect AND in all UM apps to date it seems to be initialised in the interface, NB: make sure this is the case when JAC is implemented.

affects serial ONLY

Issue migrated from trac:317 at 2023-11-27 11:39:55 +1100

penguian commented 2 years ago

@jxs599@nci.org.au edited the issue description

penguian commented 2 years ago

@jxs599@nci.org.au changed status from new to closed

penguian commented 2 years ago

@jxs599@nci.org.au set resolution to fixed

penguian commented 2 years ago

@jxs599@nci.org.au edited the issue description

penguian commented 2 years ago

@jxs599@nci.org.au changed milestone from 3. Implementation to 1. Closed

penguian commented 1 year ago

@ccc561@nci.org.au _changed keywords from cable_runtime % offline, initialisation, snow % t_snwlr to cable_runtime % offline, initialisation, snow % t_snwlr maygit_