defect in "report_parameters"

[penguian]

keyword_nogit resolution_fixed type_defect | by yxw599

---

When the number of patches within a land cell is >10, the code crashes in subroutine report_parameters.

I think that it is a printing format issue.

---

Issue migrated from trac:329 at 2023-11-27 11:41:14 +1100

[penguian]

@jxs599@nci.org.au commented

---

It seems fro YP's description of the error that this is the problematic line (one of them anyway)

WRITE(patchfmtr,'(A8, I1, A6)') '(4X,A50,', landpt(e)%nap, 'F12.4)'

This is writing '(4X,A50,', landpt(e)%nap, 'F12.4)' to patchfmtr with FORMAT described by: '(A8, I1, A6)' The I1 describes an inner with 1 digit.

The fix should be to increase the integer digits available to WRITE out variable landpt(e)%nap to I2.

pushed @ 20d04173c8cfd693cf13ec2e24a607c8cf8174e2

However, the declared length of patchfmtr has to also be increased by 1.

I do not have access to the forcing data in which a cell has 10 patches. Therefore I will push the change and request YP to test it. Build and run with GSWP2 checks out fine - as expected anyway

[penguian]

@jxs599@nci.org.au changed status from new to closed

[penguian]

@jxs599@nci.org.au changed owner from jxs599 to reporter

[penguian]

@jxs599@nci.org.au changed component from JAC readiness to offline

[penguian]

@jxs599@nci.org.au set resolution to fixed

[penguian]

@jxs599@nci.org.au changed milestone from 6. Report to 1. Closed

[penguian]

@ccc561@nci.org.au set keywords to nogit