search

CABLE-LSM / CABLE-Trac-archive

Archive CABLE Trac contents as issues
Other
0 stars 0 forks source link

ESM1.5 Reconciliation - wetLeaf #341

Closed penguian closed 1 year ago

penguian commented 2 years ago

keyword_maygit owner:jxs599@nci.org.au resolution_fixed type_defect | by yh4968

esm15_wetLeaf switch in the process of merging CABLE3 into ESM15.

Changes in code (CABLE3-ESM): canopy_fwet(j) = MAX( 0.0, MIN( 1.0, 0.8 * canopy_cansto(j) / MAX( cansat(j), 0.01 ) ) ) moved from cbl_wetleaf.F90 to cbl_dryLeaf.F90 Effect on carbon: Tiny Recommendation: accept changes and remove the switch

Issue migrated from trac:341 at 2023-11-27 11:42:36 +1100

penguian commented 2 years ago

@rml599@nci.org.au commented

Relevant files:

https://trac.nci.org.au/svn/cable/branches/Share/ESM15-CABLE3_draft1/science/canopy/cbl_wetleaf.F90

https://trac.nci.org.au/svn/cable/branches/Share/ESM15-CABLE3_draft1/science/canopy/cbl_dryLeaf.F90

Still unclear why this has been moved - perhaps because of order of calling dryleaf and wetleaf

current switches would calculate in both places

trunk has initialisation in surface_wetness - call at start of canopy module. In esm, calculated in both dry/wetleaf

This is surface_wetness always called canopy%fwet = MAX( 0.0, MIN( 0.9, 0.8 * canopy%cansto / & MAX( cansat, 0.01 ) ) )

Testing has only checked whether it's used the dryleaf or wetleaf versions but both are the same and different to surface_wetness. Therefore need to test with both switched off.

Change switch esm15_dryleaf to wetleaf to do the test. Once test done, still hope to get rid of both calculations in dryleaf and wetleaf, and make sure if is in surface_wetness

penguian commented 1 year ago

@jxs599@nci.org.au changed status from new to closed

penguian commented 1 year ago

@jxs599@nci.org.au set resolution to fixed

penguian commented 1 year ago

@jxs599@nci.org.au set milestone to 1. Closed

penguian commented 1 year ago

@ccc561@nci.org.au set keywords to maygit