search

CABLE-LSM / CABLE-Trac-archive

Archive CABLE Trac contents as issues
Other
0 stars 0 forks source link

ESM1.5 Reconciliation - esm15_HDM #342

Closed penguian closed 1 year ago

penguian commented 2 years ago

keyword_maygit owner:jxs599@nci.org.au resolution_fixed type_defect | by yh4968

esm15_HDM switch in the process of merging CABLE3 into ESM15. Changes in code (CABLE3-ESM): The following code is added to cbl_pot_evap_snow.F90 IF( ssnow_snowd(j)>1.0 .OR. ssnow_tgg(j) .EQ. Ctfrz ) THEN dqu(j) = MAX( -0.1e-3, dqu(j)) ELSEIF (dq(j) .LE. 0.0 .AND. dqu(j) .LT. dq(j)) THEN dqu(j) = dq(j) ELSEIF (dq(j) .GE. 0.0 .AND. dqu(j) .LT. 0.0) THEN dqu(j) = 0.0 ENDIF Effect on climate (left: precipitation; right: temperature (kelvin), Unit: percentage relative change, ):

Effect on carbon (left: GPP; right: NPP, Unit: percentage relative change):: None Recommendation: accept changes and remove the switch

Issue migrated from trac:342 at 2023-11-27 11:42:42 +1100

penguian commented 2 years ago

@yh4968@nci.org.au uploaded file Picture1.gif (6.9 KiB)

Changes in temperature (esm15_HDM)

penguian commented 2 years ago

@rml599@nci.org.au commented

Relevant file:

https://trac.nci.org.au/svn/cable/branches/Share/ESM15-CABLE3_draft1/science/canopy/cbl_pot_evap_snow.F90

Bug in trunk, ssnow%rh_srf not initialised.

Implications for dq_unsat calculation. Might need to check what happened in CM2.

Calculation of dqu - trunk has elseif options, not in esm? Had elseif options been added for groundwater??

CLaire/Jhan/Ramzi - to clarify

penguian commented 2 years ago

@ccc561@nci.org.au commented

After investigation, dqu (in Humidity_deficit_method function) and dq_unsat in cable_canopy.F90 are only used for GW.

The IF statements above should have no impact on ESM. But right now, ESM1.5 has no proper initialisation of rh_srf (which has no impact on the results but should still be present). We can use the one from CABLE3 in canopy/cbl_SurfaceWetness.F90:

    IF( .NOT. cable_runtime%esm15_dryLeaf ) THEN
       !call saturated_fraction(ssnow,soil,veg)
       ssnow%satfrac(:) = 1.0e-8
       ssnow%rh_srf(:)  = 1.0
    END IF

Note: I don't know about ssnow%satfrac here. See the esm15_dryLeaf ticket #350 for this.

Generally, for CABLE3, we should:

But these 2 items are a different ticket all completely.

penguian commented 2 years ago

@ccc561@nci.org.au changed _comment0 which not transferred by tractive

penguian commented 1 year ago

@jxs599@nci.org.au changed status from new to closed

penguian commented 1 year ago

@jxs599@nci.org.au set resolution to fixed

penguian commented 1 year ago

@jxs599@nci.org.au set milestone to 1. Closed

penguian commented 1 year ago

@ccc561@nci.org.au set keywords to maygit