search

CABLE-LSM / CABLE-Trac-archive

Archive CABLE Trac contents as issues
Other
0 stars 0 forks source link

ESM1.5 Reconciliation - esm15_within_canopy #344

Closed penguian closed 1 year ago

penguian commented 1 year ago

keyword_maygit owner:jxs599@nci.org.au resolution_fixed type_defect | by yh4968

Changes in code (CABLE3-ESM): The following code was changed in cbl_within_canopy.F90 IF( cable_runtime%esm15_within_canopy ) THEN fix_eqn(:) = ssnow%wetfac(:) fix_eqn2(:) = 1.0 ELSE IF (cable_user%or_evap) THEN fix_eqn(:) = rt0(:)(REAL(ssnow%satfrac(:))/(rt0(:)+REAL(ssnow%rtevap_sat(:))) + & (1-REAL(ssnow%satfrac(:)))/(rt0(:)+REAL(ssnow%rtevap_unsat(:)))) !lakes/ice rtevap=0 and wetfac is .ne. 1 fix_eqn(:) = ssnow%wetfac(:) fix_eqn(:)ssnow%cls(:) !INH correction. & M.Dekker +d wetfac fix_eqn2(:) = rt0(:) / (rt0(:) + REAL(ssnow%rt_qh_sublayer) ) ELSE !with INH corrections for litter and cls fix_eqn(:) = ssnow%cls(:)rt0(:)/(rt0(:)+relitt(:)) WHERE (ssnow%potev>0.) fix_eqn(:)=fix_eqn(:)*ssnow%wetfac(:) fix_eqn2(:) = rt0(:)/(rt0(:)+rhlitt(:)) END IF END IF

IF( cable_runtime%esm15_within_canopy ) THEN dmce(j) = ((1.+air%epsi(j))rrsw(j) + rrbw(j))rt0(j)rough%rt1(j) & (canopy%fev(j) + canopy%fes(j))/(air%rho(j)air%rlam(j)) ELSE dmce(j) = ((1.+air%epsi(j))rrsw(j) + rrbw(j))rt0(j)rough%rt1(j) & (canopy%fev(j) + canopy%fes(j)/ssnow%cls(j)) / & (air%rho(j)air%rlam(j)) END IF

Issue migrated from trac:344 at 2023-11-27 11:42:56 +1100

penguian commented 1 year ago

@rml599@nci.org.au commented

https://trac.nci.org.au/svn/cable/branches/Share/ESM15-CABLE3_draft1/science/canopy/cbl_within_canopy.F90

First instance is a likely improvement for CM2 (given INH comment) - so likely want to adopt/keep.

If this switch is off and other esm switches are on, doesn't run - therefore dependency on another change somewhere - likely code changes described in #349.

See #137 for Ian's documentation of these changes.

penguian commented 1 year ago

@rml599@nci.org.au changed _comment0 which not transferred by tractive

penguian commented 1 year ago

@jxs599@nci.org.au changed status from new to closed

penguian commented 1 year ago

@jxs599@nci.org.au set resolution to fixed

penguian commented 1 year ago

@jxs599@nci.org.au set milestone to 1. Closed

penguian commented 1 year ago

@ccc561@nci.org.au set keywords to maygit