Closed penguian closed 1 year ago
@yh4968@nci.org.au uploaded file switches -rad.docx
(47.9 KiB)
@rml599@nci.org.au commented
Three differences.
! Define fraction of SW beam tranmitted through canopy:
IF( cable_runtime%esm15_rad) THEN
dummy2 = -rad%extkb * canopy%vlaiw
dummy = EXP(dummy2)
ELSE
dummy2 = MIN(rad%extkb * canopy%vlaiw,30.) ! vh version to avoid floating underflow !
dummy = EXP(-dummy2)
ENDIF
Insignificant sign change (happens in both lines). Minimum set, note comment from vh. Likely accept this change.
IF( cable_runtime%esm15_rad) THEN
VegTemp = met%tk
ELSE
VegTemp = met%tvrad
ENDIF
Quick check suggests met%vrad is always the same as met%tk but should double-check. Is one preferred if in future the two temperatures were different?
IF( cable_runtime%esm15_rad) THEN
WHERE (sunlit_veg_mask) ! i.e. vegetation and sunlight are present
CanopyExtincion_beam = EXP( -rad%extkbm(:,1) * canopy%vlaiw )
CanopyExtincion_dif = EXP( -rad%extkdm(:,1) * canopy%vlaiw )
END WHERE
ELSE
WHERE (sunlit_veg_mask) ! i.e. vegetation and sunlight are present
CanopyExtincion_beam = EXP( -MIN(rad%extkbm(:,1) * canopy%vlaiw,20.) )
CanopyExtincion_dif = EXP( -MIN(rad%extkdm(:,1) * canopy%vlaiw,20.) )
END WHERE
ENDIF
Similar condition as first change, but minimum 20 not 30. Why different? Is it extkdm instead of extkd?
Check the difference in init_radiation (#343). Possible esm has similar condition (minimum) set in initialisation rather than here. May be that don't need the init one if keep the ones here?
Apparently little impact on temp/precip (probably as expected since condition may not be triggered often?). GPP showing small reduction but perhaps just 'random'??
@rml599@nci.org.au changed _comment0 which not transferred by tractive
@rml599@nci.org.au changed _comment1 which not transferred by tractive
@jxs599@nci.org.au changed status from new
to closed
@jxs599@nci.org.au set resolution to fixed
@jxs599@nci.org.au set milestone to 1. Closed
@ccc561@nci.org.au set keywords to maygit
keyword_maygit
owner:jxs599@nci.org.au
resolution_fixed
type_defect
| by yh4968see attachment
Issue migrated from trac:346 at 2023-11-27 11:43:09 +1100