CABLE-LSM / CABLE-Trac-archive

Archive CABLE Trac contents as issues
Other
0 stars 0 forks source link

ESM1.5 Reconciliation - esm15 #351

Closed penguian closed 1 year ago

penguian commented 1 year ago

keyword_CASA-CNP keyword_carbon_cycle_maygit resolution_fixed type_model improvement | by yh4968


see attachment

Im hijacking this Ticket to make fundamental changes to the trunk in readiness for ESM1.5 recocilliation


Issue migrated from trac:351 at 2023-11-27 11:43:48 +1100

penguian commented 1 year ago

@yh4968@nci.org.au uploaded file switches-esm15.docx (47.6 KiB)

penguian commented 1 year ago

@yh4968@nci.org.au commented


https://trac.nci.org.au/trac/cable/browser/branches/Share/ESM15-CABLE3_draft1/science/soilsnow/cbl_soilfreeze.F90

Check code differences - may be that does the same but set in a different place.

https://trac.nci.org.au/trac/cable/browser/branches/Share/ESM15-CABLE3_draft1/science/soilsnow/cbl_snowAccum.F90

https://trac.nci.org.au/trac/cable/browser/branches/Share/ESM15-CABLE3_draft1/science/soilsnow/cbl_soilsnow_main.F90

https://trac.nci.org.au/trac/cable/browser/branches/Share/ESM15-CABLE3_draft1/science/soilsnow/cbl_stempv.F90

https://trac.nci.org.au/trac/cable/browser/branches/Share/ESM15-CABLE3_draft1/science/roughness/cable_roughness.F90

https://trac.nci.org.au/trac/cable/browser/branches/Share/ESM15-CABLE3_draft1/science/roughness/cbl_lai_eff.F90

https://trac.nci.org.au/trac/cable/browser/branches/Share/ESM15-CABLE3_draft1/science/soilsnow/cbl_surfbv.F90

penguian commented 1 year ago

@rml599@nci.org.au changed _comment0 which not transferred by tractive

penguian commented 1 year ago

@jxs599@nci.org.au edited the issue description

penguian commented 1 year ago

@jxs599@nci.org.au changed component from JAC readiness to model

penguian commented 1 year ago

@jxs599@nci.org.au changed owner from jxs599 to reporter

penguian commented 1 year ago

@jxs599@nci.org.au set milestone to 3. Implementation

penguian commented 1 year ago

@jxs599@nci.org.au set keywords to CASA-CNP, carbon cycle

penguian commented 1 year ago

@jxs599@nci.org.au changed type from defect to model improvement

penguian commented 1 year ago

@jxs599@nci.org.au commented


Im hijacking this Ticket to make fundamental changes to the trunk in readiness for ESM1.5 recocilliation

penguian commented 1 year ago

@jxs599@nci.org.au commented


Work for this ticket is completed in branch.

This branch contains revisions to split casa files, move those applicable to offline and coupled applications into offline and coupled directories. This is not complete, but sufficient to manage the main task here which is to update the version of CABLE in the ESM.

The "modifications" are mostly just pulling a subroutine(s) out of a larger module (in casa-cnp/) and adding it to its own file/module. Necessary plumbing modifications are then made to USE new, appropriate MODULEs. Corresponding modifications are necessary to the Makefile. Some redundant files are removed. Some trivial formatting changes were made along the way.

THIS REVISION DOES NOT CHANGE ANY RESULTS AND REPRODUCES (BITWISE) THE TRUNK FROM THE PREVIOUS REVISION.

The modifications in each main directory off root follow:

97fd8ed400bbae54454d3bf33f33a698681022a3 coupled/ - Absolutely irrelevant to all offline applications anyway. 3 redundant files are deleted

17d57006abca901b12c14865b30db6e2a91239ee params/ - remove redundant file

91e5a800000f9c096b53fdf3fa549b04ef7c111e util/ - remove redundant files

d9f79c02c6486bae41ac0b2f6a5941a06b1b90a6 offline/ - added casa files that are only relevant to offline anyway. moved out from the science code that WILL be used as a whole across all applications. These added files come from either already whole casa files OR they come from split off subroutines from larger files. Modifications to accomodate USEing subroutines from new MODULEs. Corresponding modifications to Makefile.

3ac7d152c26e1d0f55d948f1eddb6ec88aa0d4df science/ - Added casa files are subroutines extracted from here.

penguian commented 1 year ago

@jxs599@nci.org.au changed _comment0 which not transferred by tractive

penguian commented 1 year ago

@jxs599@nci.org.au changed status from new to closed

penguian commented 1 year ago

@jxs599@nci.org.au set resolution to fixed

penguian commented 1 year ago

@jxs599@nci.org.au changed milestone from 3. Implementation to 1. Closed

penguian commented 1 year ago

@ccc561@nci.org.au changed keywords from CASA-CNP, carbon cycle to CASA-CNP, carbon cycle maygit