search

CABLE-LSM / CABLE-Trac-archive

Archive CABLE Trac contents as issues
Other
0 stars 0 forks source link

Reconcile trunk post update in ACCESS-CM2 #360

Closed penguian closed 1 year ago

penguian commented 1 year ago

keyword_nogit owner:jxs599@nci.org.au resolution_fixed type_model improvement | by srb001@csiro.au

TRAC:

https://trac.nci.org.au/trac/cable/browser/branches/Users/jxs599/CABLE/Tickets/2022/360_draft1

Issue migrated from trac:360 at 2023-11-27 11:44:41 +1100

penguian commented 1 year ago

@jxs599@nci.org.au edited the issue description

penguian commented 1 year ago

@jxs599@nci.org.au commented

Correcting mistake in the trunk that used version of cumin peculiar to ESM1.5 in params/cable_phys_constants_mod.F90. umin was decreased to 0.1 in ACCESS-CM2 to guarantee convergence.

penguian commented 1 year ago

@jxs599@nci.org.au commented

Otherwise, i.e. using umin=0.01, returns EXACTLY the trunk

penguian commented 1 year ago

@jxs599@nci.org.au changed status from new to closed

penguian commented 1 year ago

@jxs599@nci.org.au set resolution to fixed

penguian commented 1 year ago

@jxs599@nci.org.au changed milestone from 3. Implementation to 1. Closed

penguian commented 1 year ago

@jxs599@nci.org.au commented

Accepted code into JULES7.2 is in sync with the trunk. Also matches CABLE version in CM2. and ESM1.5, less there last few revisions which should not be an issue

penguian commented 1 year ago

@ccc561@nci.org.au set keywords to nogit