[build.bash] Use curly braces everywhere instead of just in potentially ambiguous cases

CABLE-LSM / CABLE

Home to the CABLE land surface model and its documentation

https://cable.readthedocs.io/en/latest/

Other

12 stars 6 forks source link

[build.bash] Use curly braces everywhere instead of just in potentially ambiguous cases #312

Closed SeanBryan51 closed 5 months ago

SeanBryan51 commented 5 months ago

All good. You can think a bout my last suggestion to have also single character options. I would also be nitpicking and put really all variables in bash scripts in curly brackets, e.g. ${1}. They are firstly easier spotted/identified and it is needed when enhancing with variable substitution, default values, etc. I just made it a habit for me.

Originally posted by @mcuntz in https://github.com/CABLE-LSM/CABLE/pull/238#pullrequestreview-2116432977

SeanBryan51 commented 5 months ago

Also relevant: https://stackoverflow.com/a/8748880