search

CABLE-LSM / CABLE

Home to the CABLE land surface model and its documentation
https://cable.readthedocs.io/en/latest/
Other
8 stars 3 forks source link

Extract recycle_met start and end dates to bios.nml #329

Open AlisonBennett opened 2 weeks ago

AlisonBennett commented 2 weeks ago

Move the recycle_met_startdate and recycle_met_enddate from their hardcoded values in cable_met_obs_params.F90 into bios.nml so that they can be user defined.

This will enable the bios met spinup period to be adjusted as needed without adjusting the code base.

Currently the values are hardcoded at: recycle_met_startdate=1981 (or 1951) L557 recycle_met_enddate=2010 (or 1980) L558

NB. the syear value at L929 is also hardcoded and should be addressed in this ticket. Either move this to the bios.nml as well or update to = recycle_met_start_date.

ccarouge commented 2 weeks ago

Because line numbers change very easily, it is better to provide a permalink to a specific version of the code:

https://github.com/CABLE-LSM/CABLE/blob/9a5bf2bfd3e3d8d33209175e314e71e882a5325f/offline/cable_bios_met_obs_params.F90#L557-L558

And for syear see:

https://github.com/CABLE-LSM/CABLE/blob/9a5bf2bfd3e3d8d33209175e314e71e882a5325f/offline/cable_bios_met_obs_params.F90#L929

This way the reference will always point to the correct place in the code. This is how you do it

AlisonBennett commented 1 week ago

Thanks - very useful to know :)

ccarouge commented 1 week ago

This is similar to what is done when rewriting the met forcing routines for CRU in CABLE-POP_TRENDY #290. Wait to work on this until we merge into CABLE-POP_TRENDY.