search

CABLE-LSM / CABLE

Home to the CABLE land surface model and its documentation
https://cable.readthedocs.io/en/latest/
Other
12 stars 6 forks source link

Add src/coupled/AM3 directory #371

Closed JhanSrbinovsky closed 2 months ago

JhanSrbinovsky commented 3 months ago

AM3 application specific see issue #370

Fixes #370

Type of change

Hopefully will cover CM3 as well

Checklist

📚 Documentation preview 📚: https://cable--371.org.readthedocs.build/en/371/

JhanSrbinovsky commented 2 months ago

@bschroeter, @ccarouge, Coming back from leave again I am trying to figure out what I was up to before I left. It seems I have been building other branches onto of a quasi-main branch that assumes these things are going to merge. Needless to say that this is less than ideal and messy. This particular "part" of the AM3 merge is by far the largest and independent of any other application. It would be good to get this in so I can go back to branching from main and not have to merge this OR branch from here etc etc

ccarouge commented 2 months ago

@JhanSrbinovsky Yesterday I was just discussing with Ben and we were wondering what is the purpose of the src/coupled/ directories? I'm not sure if these files are ever used and if the goal is to eventually use them. Could you clarify please?

JhanSrbinovsky commented 2 months ago

I'm assuming you mean these:

coupled/
├── ACCESS-CM2
├── ESM1.5
├── JAC
└── shared

These are all the drivers per coupled applications which "were" supported. So for ESM1.5, the CABLE component grabs

├── coupled/ESM1.5
├── coupled/shared
├── params
├── science
└── util

offline builds grabbed:

├── offline
├── params
├── science
└── util

coupled/ are somewhat redundant redundant as unless actually in the appropriate JULES/UM7.3 they are useless. It was more or less like not being able to throw them away. In theory, it is (and has) been the case that having them locally to at least consult (document) is useful. In theory specific application dirs should get smaller as things are dealt with in coupled/shared/, however the reality is that we've rarely had time AND a checkout of the relevant parent would be in the picture anyway.