CABLE-LSM / CABLE

Home to the CABLE land surface model and its documentation

https://cable.readthedocs.io/en/latest/

Other

8 stars 4 forks source link

Pipe BIOS met data through CRU routines for weather generation #394

Open Whyborn opened 3 weeks ago

Whyborn commented 3 weeks ago

CABLE

Thank you for submitting a pull request to the CABLE Project.

Description

Piping the BIOS met inputs (the AGCD dataset) through the routines developed for the CRU routines. There are two options:

Make some adjustments to the existing CRU routines to have different options for weather generators, so that it uses the appropriate fields to prepare the weather generator.
Leave the BIOS met routines where they are, but make the file look very similar to the offline/cable_cru_TRENDY.F90 file.

Upside of 1 is that it paves the way for work necessary in the long term for generalising inputs. Only upside to 2 is that is it probably easier, but not necessarily. Both approaches require some thorough investigation to determine which bits of the BIOS init routines are only relevant to the met forcing, and which are relevant to BLAZE.

Fixes #391

Type of change

Please delete options that are not relevant.

[x] New feature

Checklist

[ ] The new content is accessible and located in the appropriate section.
[ ] I have checked that links are valid and point to the intended content.
[ ] I have checked my code/text and corrected any misspellings

Please add a reviewer when ready for review.

AlisonBennett commented 3 weeks ago

My 2 cents worth. I think option 1 would result in a better long-term outcome for CABLE as generalised input routines mean the potential for CABLE to accept any compatible input data, making it more suitable to a broader range of applications. But, we will need to be careful that any BIOS specific met-handling is dealt with.

From: Lachlan Whyborn @.> Sent: Friday, 6 September 2024 16:19 To: CABLE-LSM/CABLE @.> Cc: Subscribed @.***> Subject: [CABLE-LSM/CABLE] Add indices for AGCD met data (PR #394)

CABLE

Thank you for submitting a pull request to the CABLE Project.

Description

Piping the BIOS met inputs (the AGCD dataset) through the routines developed for the CRU routines. There are two options:

Make some adjustments to the existing CRU routines to have different options for weather generators, so that it uses the appropriate fields to prepare the weather generator.
Leave the BIOS met routines where they are, but make the file look very similar to the offline/cable_cru_TRENDY.F90 file.

Upside of 1 is that it paves the way for work necessary in the long term for generalising inputs. Only upside to 2 is that is it probably easier, but not necessarily. Both approaches require some thorough investigation to determine which bits of the BIOS init routines are only relevant to the met forcing, and which are relevant to BLAZE.

Fixes #(391)

Type of change

Please delete options that are not relevant.

New feature

Checklist

The new content is accessible and located in the appropriate section.
I have checked that links are valid and point to the intended content.
I have checked my code/text and corrected any misspellings

Please add a reviewer when ready for review.

You can view, comment on, or merge this pull request online at:

https://github.com/CABLE-LSM/CABLE/pull/394

Commit Summary

6ea04ebhttps://github.com/CABLE-LSM/CABLE/pull/394/commits/6ea04ebce05292ed212fb0864f97439dec5146d0 Add indices for AGCD met data

File Changes

(1 filehttps://github.com/CABLE-LSM/CABLE/pull/394/files)

M offline/cable_cru_TRENDY.F90https://github.com/CABLE-LSM/CABLE/pull/394/files#diff-bb842d4076adb5dbf110c7e1c61aa1196783d8843ffc24d0972e11f188639975 (6)

Patch Links:

— Reply to this email directly, view it on GitHubhttps://github.com/CABLE-LSM/CABLE/pull/394, or unsubscribehttps://github.com/notifications/unsubscribe-auth/AIL5VYWNEPLXYR5JGYDSP6LZVFCNPAVCNFSM6AAAAABNX44JDKVHI2DSMVQWIX3LMV43ASLTON2WKOZSGUYDSNRRGIYTMMY. You are receiving this because you are subscribed to this thread.Message ID: @.***>