CABLE-LSM / CABLE

Home to the CABLE land surface model and its documentation
https://cable.readthedocs.io/en/latest/
Other
12 stars 6 forks source link

415 non allocated arrays accessed in output #456

Closed micaeljtoliveira closed 3 weeks ago

micaeljtoliveira commented 3 weeks ago

CABLE

Description

Refactor the output and fence all calls to the generate_out_write_acc subroutine such that no non-allocated arrays are accessed.

Fixes #415

Type of change

Please delete options that are not relevant.

Checklist


📚 Documentation preview 📚: https://cable--456.org.readthedocs.build/en/456/

micaeljtoliveira commented 3 weeks ago

@SeanBryan51 With these changes I can now run the executable compiled with gfortran.

SeanBryan51 commented 3 weeks ago

Thanks @micaeljtoliveira, this looks great. I'll run these changes through benchcab to check for bitwise equivalent outputs with main