search

CABLE-LSM / benchcab

Tool for evaluation of CABLE land surface model
https://benchcab.readthedocs.io/en/latest/
Apache License 2.0
2 stars 4 forks source link

Better error handling in PBS job script #158

Closed SeanBryan51 closed 1 year ago

SeanBryan51 commented 1 year ago

A better way of error handling in the PBS job script is to use set -e instead of a using bunch of if statements:

https://github.com/CABLE-LSM/benchcab/blob/b5fe7fd12c2670c15a4d4b8269cfdccce521fede/benchcab/utils/pbs.py#L53-L62

Helpful resource: https://intoli.com/blog/exit-on-errors-in-bash-scripts/

ccarouge commented 1 year ago

Hey team! Please add your planning poker estimate with Zenhub @bschroeter @SeanBryan51

bschroeter commented 1 year ago

See #158 for additional information.

This could be handled in #142 when we switch to Jinja2.

Voting heavy to align with other issues.