search

CABLE-LSM / benchcab

Tool for evaluation of CABLE land surface model
https://benchcab.readthedocs.io/en/latest/
Apache License 2.0
2 stars 4 forks source link

Absolute paths in logged standard output #162

Closed SeanBryan51 closed 11 months ago

SeanBryan51 commented 1 year ago

Logged standard output shouldn't write full absolute paths. Paths should be relative to the current working directory where possible to improve readability.

For example, in the code below we should remove {MOCK_CWD}/ from the f-strings:

https://github.com/CABLE-LSM/benchcab/blob/b5fe7fd12c2670c15a4d4b8269cfdccce521fede/tests/test_fluxsite.py#L311-L320

SeanBryan51 commented 1 year ago

Hey team! Please add your planning poker estimate with Zenhub @ccarouge @bschroeter

SeanBryan51 commented 1 year ago

Some tests have been implemented for this in #172 but are currently being skipped:

https://github.com/CABLE-LSM/benchcab/blob/058f465a807e09cd87723cec3df5f5ec1d985a00/tests/test_comparison.py#L81-L85

https://github.com/CABLE-LSM/benchcab/blob/058f465a807e09cd87723cec3df5f5ec1d985a00/tests/test_fluxsite.py#L273-L277

https://github.com/CABLE-LSM/benchcab/blob/058f465a807e09cd87723cec3df5f5ec1d985a00/tests/test_fluxsite.py#L391-L395

https://github.com/CABLE-LSM/benchcab/blob/058f465a807e09cd87723cec3df5f5ec1d985a00/tests/test_repository.py#L306-L309

When implementing this issue, these tests should pass.