CABLE-LSM / benchcab

Tool for evaluation of CABLE land surface model
https://benchcab.readthedocs.io/en/latest/
Apache License 2.0
2 stars 3 forks source link

Deprecate PBR build dependency #228

Closed SeanBryan51 closed 8 months ago

SeanBryan51 commented 8 months ago

PBR is removed from the build dependencies so that we can use versioneer to solve #129. This change removes the additional options provided by PBR in setup.cfg or replaces these options with the default options that come with setuptools.

Fixes #227

codecov[bot] commented 8 months ago

Codecov Report

Attention: 1 lines in your changes are missing coverage. Please review.

Comparison is base (db6b941) 82.34% compared to head (3304b9e) 82.34%. Report is 1 commits behind head on main.

Files Patch % Lines
setup.py 0.00% 1 Missing :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #228 +/- ## ======================================= Coverage 82.34% 82.34% ======================================= Files 28 28 Lines 1410 1410 ======================================= Hits 1161 1161 Misses 249 249 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

SeanBryan51 commented 8 months ago

Commands tested

bschroeter commented 8 months ago

Commands tested

  • Test conda installation:
conda build -c conda-forge .
conda install -c conda-forge --use-local benchcab
/bin/bash benchcab/data/test/integration.sh
  • Test pip install
pip install --user .
/bin/bash benchcab/data/test/integration.sh

I take it these passed without failure?

SeanBryan51 commented 8 months ago

@bschroeter yes commands ran successfully.