Closed SeanBryan51 closed 10 months ago
Attention: 634 lines
in your changes are missing coverage. Please review.
Comparison is base (
db6b941
) 82.34% compared to head (e5c2a74
) 58.23%. Report is 2 commits behind head on main.
Files | Patch % | Lines |
---|---|---|
versioneer.py | 9.95% | 633 Missing :warning: |
setup.py | 0.00% | 1 Missing :warning: |
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
Testing pip install --user .
:
$ pip install --user -q . && pip list | grep benchcab
benchcab 3.0.0+13.ge5c2a74
Testing pip install -e .
$ pip install -e .
Obtaining file:///home/189/sb8430/benchcab
Preparing metadata (setup.py) ... done
Installing collected packages: benchcab
Running setup.py develop for benchcab
Successfully installed benchcab-3.0.0+13.ge5c2a74
Testing conda build -c conda-forge .
:
$ conda search --use-local benchcab
Loading channels: done
# Name Version Build Channel
benchcab 3.0.0+13.ge5c2a74 py_13 scratch/tm70/sb8430/conda/bld
Previously (prior to #228), we used the PBR package with an explicit version number in setup.cfg. This enables the 'pre-versioning' mode of managing version strings (see features) which raises an error if the inferred version from Git tags is greater than explicit version in setup.cfg. This prevents developers from doing an editable install via
pip install -e .
(see #129). This issue was fixed implicitly in #228 when PBR was removed from the build dependencies.This change is a feature in that it implements dynamic version strings from Git tags via versioneer so that an explicit version number in setup.cfg is not required. We choose versioneer so that version strings were consistent across
pip
andconda
installations. This was not possible with other tools such as PBR and setuptools_scm.Fixes #129