Remove svn dependency in default runs

CABLE-LSM / benchcab

Tool for evaluation of CABLE land surface model

https://benchcab.readthedocs.io/en/latest/

Apache License 2.0

2 stars 4 forks source link

Remove svn dependency in default runs #236

Closed abhaasgoyal closed 9 months ago

abhaasgoyal commented 10 months ago

Fixes #230

Merge Message When running benchcab, it checks out on svn branch, potentially for data files like GRID_DATA. This commit:

Removes the dependency to check out in svn branch
Cleans up internal variables for unused files
Uses alternative sources for existing data files in svn - testing was done via bitwise comparison generated by main vs 230-remove-svn-dependency branch during integration tests

codecov[bot] commented 10 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Comparison is base (e875575) 58.23% compared to head (d1d6280) 58.22%. Report is 1 commits behind head on main.

Additional details and impacted files

```diff @@ Coverage Diff @@ ## main #236 +/- ## ========================================== - Coverage 58.23% 58.22% -0.01% ========================================== Files 29 29 Lines 2114 2109 -5 ========================================== - Hits 1231 1228 -3 + Misses 883 881 -2 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

abhaasgoyal commented 10 months ago

@ccarouge can you run benchcap for comparison on CABLE_AUX?

ccarouge commented 9 months ago

Comparison of benchcab with the gridinfo file from CABLE-AUX branch and with a gridinfo file in rp23 has been done. It has shown differences in the results. This is surprising and might require further investigation on the CABLE side later on.

To move on here, we will look at adding the CABLE-AUX data under /g/data/wd9 for the moment. This will change once we have a well-documented gridinfo file we can use instead.