CABLE-LSM / benchcab

Tool for evaluation of CABLE land surface model
https://benchcab.readthedocs.io/en/latest/
Apache License 2.0
2 stars 4 forks source link

Clean parsing of optional `config.yaml` data #238

Closed abhaasgoyal closed 9 months ago

abhaasgoyal commented 10 months ago

Fixes #234, #239

Merge Message

codecov[bot] commented 9 months ago

Codecov Report

Attention: 5 lines in your changes are missing coverage. Please review.

Comparison is base (d1d6280) 58.22% compared to head (2efcd48) 59.13%. Report is 1 commits behind head on main.

Files Patch % Lines
benchcab/benchcab.py 0.00% 4 Missing :warning:
tests/test_config.py 97.36% 1 Missing :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #238 +/- ## ========================================== + Coverage 58.22% 59.13% +0.90% ========================================== Files 29 29 Lines 2109 2129 +20 ========================================== + Hits 1228 1259 +31 + Misses 881 870 -11 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

ccarouge commented 9 months ago

Actually, can we rename read_optional_data? I don't like the use of data here. In the doc, we are using key for the entries in the config file maybe that's the best choice.