search

CABLE-LSM / benchcab

Tool for evaluation of CABLE land surface model
https://benchcab.readthedocs.io/en/latest/
Apache License 2.0
2 stars 4 forks source link

Use cable local checkout #255

Closed abhaasgoyal closed 8 months ago

abhaasgoyal commented 8 months ago

Resolves #33

Merge Message

codecov[bot] commented 8 months ago

Codecov Report

Attention: Patch coverage is 70.52632% with 28 lines in your changes are missing coverage. Please review.

Project coverage is 63.84%. Comparing base (ce3608e) to head (ac2cb1f). Report is 1 commits behind head on main.

Files Patch % Lines
benchcab/utils/repo.py 22.72% 17 Missing :warning:
benchcab/benchcab.py 8.33% 11 Missing :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #255 +/- ## ========================================== + Coverage 63.50% 63.84% +0.33% ========================================== Files 35 35 Lines 2521 2597 +76 ========================================== + Hits 1601 1658 +57 - Misses 920 939 +19 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

abhaasgoyal commented 8 months ago

https://github.com/CABLE-LSM/benchcab/blob/4d31d37c233a591998d5bacbfd624a0c75cfe516/docs/user_guide/index.md?plain=1#L220

Here (see surrounding lines as well), it is suggested to remove rev_number-* as well, I will change it to benchcab clean all here, however should we reatain rev_number-* according to the comment https://github.com/CABLE-LSM/benchcab/pull/255#pullrequestreview-1918246705

Edit: the changes are done here in case if there's any change required https://github.com/CABLE-LSM/benchcab/blob/d2948661ace7ccbd63fc83797ea0b0cfdddc3976/docs/user_guide/index.md?plain=1#L220